| Summary: | CodeBlockSet::deleteUnmarkedAndUnreferenced can be a little more efficient | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 165909 | ||||||
| Attachments: |
|
||||||
|
Description
Filip Pizlo
2017-11-28 13:48:13 PST
Created attachment 327784 [details]
the patch
Comment on attachment 327784 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=327784&action=review r=me > Source/JavaScriptCore/heap/CodeBlockSet.cpp:31 > +#include "SuperSampler.h" You're not using this AFAICT > Source/JavaScriptCore/heap/CodeBlockSet.cpp:87 > + // FIXME: make CodeBlock::~CodeBlock a lot faster. It seems insane for that to take 1us or more. Indeed. That's crazy |