Bug 180064
Summary: | [Meta][CMake] Forwarding headers should be copies | ||
---|---|---|---|
Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW | ||
Severity: | Normal | CC: | annulen, fujii.hironori, lforschler, ossy |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | 180063, 182274, 182303, 182347, 182512, 182645 | ||
Bug Blocks: | 196704 |
Don Olmstead
Meta bug for tracking copying forwarding headers within CMake to align with Apple ports.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Konstantin Tokarev
No they should not
Csaba Osztrogonác
(In reply to Konstantin Tokarev from comment #1)
> No they should not
I agree, we shouldn't do terrible hacks just because Apple Windows port does.
Don Olmstead
(In reply to Csaba Osztrogonác from comment #2)
> (In reply to Konstantin Tokarev from comment #1)
> > No they should not
>
> I agree, we shouldn't do terrible hacks just because Apple Windows port does.
We already litigated this in https://bugs.webkit.org/show_bug.cgi?id=180063 with mcatanzaro agreeing to the direction on the GTK/WPE side. A patch that copies JavaScriptCore headers is going through the bots now.