LayoutTest http/tests/workers/service/registration-clear-redundant-worker.html is a flaky failure

• Component: New Bugs
• Status: RESOLVED FIXED

[Ryan Haddad]

LayoutTest http/tests/workers/service/registration-clear-redundant-worker.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r224920%20(6022)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fworkers%2Fservice%2Fregistration-clear-redundant-worker.html

--- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/http/tests/workers/service/registration-clear-redundant-worker-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/http/tests/workers/service/registration-clear-redundant-worker-actual.txt
@@ -2,5 +2,5 @@
 PASS: Worker became redundant after unregistering
 PASS: registration.installing is null
 PASS: registration.waiting is null
-PASS: registration.active is null
+FAIL: registration.active should be null

[Ryan Haddad]

This test was added with https://trac.webkit.org/changeset/224710/webkit

[Chris Dumez]

Ok, will take a look.

[Chris Dumez]

https://bugs.webkit.org/show_bug.cgi?id=179745 & https://bugs.webkit.org/show_bug.cgi?id=179751 may help here.

[Ryan Haddad]

Marked test as flaky in https://trac.webkit.org/changeset/225304/webkit

[Chris Dumez]

(In reply to Ryan Haddad from comment #4)
> Marked test as flaky in https://trac.webkit.org/changeset/225304/webkit

Ok, I'll take another look then.

[Chris Dumez]

Was able to reproduce like so:
Tools/Scripts/run-webkit-tests --repeat-each=100 http/tests/workers/service/registration-clear-redundant-worker.html -f

[Chris Dumez]

Created attachment 327927 [details]
Patch

[Chris Dumez]

Created attachment 327928 [details]
Patch

[youenn fablet]

Comment on attachment 327928 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327928&action=review

> LayoutTests/http/tests/workers/service/registration-clear-redundant-worker.html:28
> +                handle = setInterval(function() {

Maybe we could add a limit to the number of retries to allow gracefully failing instead of timing out.
Something like 100 tries every 10 ms for instance.

[WebKit Commit Bot]

Comment on attachment 327928 [details]
Patch

Clearing flags on attachment: 327928

Committed r225312: <https://trac.webkit.org/changeset/225312>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35763630>