Bug 179620

Summary: Don't eliminate whitespace renderer if the previous sibling is a text renderer
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, rniwa, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 157477    
Attachments:
Description Flags
patch
none
patch none

Antti Koivisto
Reported 2017-11-13 10:59:26 PST
Currently whitespace elimination code doesn't consider runs of text renderers. We should always make whitespace renderer if the previous renderer is a text renderer. The behavior should be the same as if those were a single renderer with merged text. This situation can happen easily with display:contents.
Attachments
patch (5.05 KB, patch)
2017-11-13 11:40 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (5.12 KB, patch)
2017-11-13 11:42 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-11-13 11:40:35 PST
Created attachment 326777 [details] patch
Antti Koivisto
Comment 2 2017-11-13 11:42:29 PST
Created attachment 326778 [details] patch
WebKit Commit Bot
Comment 3 2017-11-13 13:14:50 PST
Comment on attachment 326778 [details] patch Clearing flags on attachment: 326778 Committed r224773: <https://trac.webkit.org/changeset/224773>
WebKit Commit Bot
Comment 4 2017-11-13 13:14:52 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-11-13 15:39:52 PST
<rdar://problem/35517807>
Note You need to log in before you can comment on or make changes to this bug.