Summary: | [WinCairo EWS] svn-apply: 'cp' is not recognized as an internal or external command | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, buildbot, commit-queue, dbates, don.olmstead, lforschler, pvollan, stephan.szabo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Fujii Hironori
2017-11-09 01:21:51 PST
Created attachment 326435 [details]
Patch
Created attachment 326436 [details]
Patch
Comment on attachment 326436 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326436&action=review > Tools/Scripts/svn-apply:65 > +use File::Copy qw(copy); Does this module exist on all platforms? (In reply to Per Arne Vollan from comment #3) > Comment on attachment 326436 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=326436&action=review > > > Tools/Scripts/svn-apply:65 > > +use File::Copy qw(copy); > > Does this module exist on all platforms? https://perldoc.perl.org/index-modules-F.html says its in the standard libraries. Also File:: is used above Looks like it's part of the standard install modules (from search.cpan.org's results looks like it's been part since at least 5.8.0) and appears to exist in standard installation on Windows and Ubuntu. Comment on attachment 326436 [details]
Patch
R=me. We'll keep an eye on the bots after this lands.
Comment on attachment 326436 [details] Patch Clearing flags on attachment: 326436 Committed r224647: <https://trac.webkit.org/changeset/224647> All reviewed patches have been landed. Closing bug. |