Bug 179391

Summary:

Make CSSOM APIs append rather than replace slots in the declaration block.

Product:

WebKit

Reporter:

Emilio Cobos Álvarez (:emilio) <emilio>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

achristensen, commit-queue, ews-watchlist, koivisto, rniwa, simon.fraser, zalan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

URL:

https://github.com/w3c/csswg-drafts/issues/1898

See Also:

https://bugs.webkit.org/show_bug.cgi?id=185805

Attachments:

Description	Flags
Patch	none
Patch (for CQ only)	none
Patch	emilio: commit-queue-
Patch	none
Patch	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews112 for mac-sierra	none
Patch	none
Patch	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews117 for mac-sierra	none
Archive of layout-test-results from ews200 for win-future	none

Description Emilio Cobos Álvarez (:emilio) 2017-11-07 14:14:43 PST

Otherwise logical properties work inconsistently with them.

See the URL for more background and the CSSWG resolution.

Comment 1 Emilio Cobos Álvarez (:emilio) 2018-05-20 12:00:56 PDT

Created attachment 340796 [details]
Patch

Comment 2 Emilio Cobos Álvarez (:emilio) 2018-05-20 12:09:44 PDT

Created attachment 340797 [details]
Patch (for CQ only)

Comment 3 Emilio Cobos Álvarez (:emilio) 2018-05-20 13:11:50 PDT

Created attachment 340801 [details]
Patch

Comment 4 Emilio Cobos Álvarez (:emilio) 2018-05-20 13:12:42 PDT

Updated a test to avoid depending on the number of properties the browser supports.

https://github.com/w3c/web-platform-tests/pull/11083

Comment 5 Emilio Cobos Álvarez (:emilio) 2018-05-20 13:16:26 PDT

Comment on attachment 340801 [details]
Patch

Err, webkit-patch-upload got really confused. This patch should've gone in bug 185805.

Comment 6 Emilio Cobos Álvarez (:emilio) 2018-05-21 05:57:27 PDT

Created attachment 340844 [details]
Patch

Comment 7 Emilio Cobos Álvarez (:emilio) 2018-05-21 08:20:55 PDT

Created attachment 340852 [details]
Patch

Comment 8 EWS Watchlist 2018-05-21 09:29:29 PDT

Comment on attachment 340852 [details]
Patch

Attachment 340852 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7753385

New failing tests:
fast/css/custom-properties/rule-property-set.html
fast/events/ondrop-text-html.html
editing/pasteboard/copy-paste-converts-sticky.html
editing/pasteboard/copy-paste-converts-fixed.html
fast/dom/MutationObserver/observe-attributes.html
fast/css/set-inline-style-recalc.html
fast/dom/css-set-property-exception.html

Comment 9 EWS Watchlist 2018-05-21 09:29:30 PDT

Created attachment 340853 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 10 EWS Watchlist 2018-05-21 09:35:26 PDT

Comment on attachment 340852 [details]
Patch

Attachment 340852 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7753392

New failing tests:
fast/css/custom-properties/rule-property-set.html
editing/pasteboard/copy-paste-converts-sticky.html
editing/pasteboard/copy-paste-converts-fixed.html
fast/dom/MutationObserver/observe-attributes.html
fast/css/set-inline-style-recalc.html
fast/dom/css-set-property-exception.html

Comment 11 EWS Watchlist 2018-05-21 09:35:28 PDT

Created attachment 340854 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

Comment 12 EWS Watchlist 2018-05-21 10:06:53 PDT

Comment on attachment 340852 [details]
Patch

Attachment 340852 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7753436

New failing tests:
fast/css/custom-properties/rule-property-set.html
editing/pasteboard/copy-paste-converts-sticky.html
editing/pasteboard/copy-paste-converts-fixed.html
fast/dom/MutationObserver/observe-attributes.html
fast/css/set-inline-style-recalc.html
fast/dom/css-set-property-exception.html

Comment 13 EWS Watchlist 2018-05-21 10:06:55 PDT

Created attachment 340856 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

Comment 14 EWS Watchlist 2018-05-21 10:16:52 PDT

Comment on attachment 340852 [details]
Patch

Attachment 340852 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7753463

New failing tests:
fast/css/custom-properties/rule-property-set.html
fast/events/ondrop-text-html.html
editing/pasteboard/copy-paste-converts-sticky.html
editing/pasteboard/copy-paste-converts-fixed.html
fast/dom/MutationObserver/observe-attributes.html
fast/css/set-inline-style-recalc.html
fast/dom/css-set-property-exception.html

Comment 15 EWS Watchlist 2018-05-21 10:16:54 PDT

Created attachment 340859 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 16 Emilio Cobos Álvarez (:emilio) 2018-05-21 11:51:21 PDT

Created attachment 340866 [details]
Patch

Comment 17 Emilio Cobos Álvarez (:emilio) 2018-05-22 01:43:29 PDT

Created attachment 340961 [details]
Patch

Comment 18 Emilio Cobos Álvarez (:emilio) 2018-05-22 02:39:06 PDT

Created attachment 340965 [details]
Patch

Comment 19 EWS Watchlist 2018-05-22 03:47:36 PDT

Comment on attachment 340965 [details]
Patch

Attachment 340965 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7763297

New failing tests:
fast/events/ondrop-text-html.html

Comment 20 EWS Watchlist 2018-05-22 03:47:38 PDT

Created attachment 340967 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 21 EWS Watchlist 2018-05-22 04:22:44 PDT

Comment on attachment 340965 [details]
Patch

Attachment 340965 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7763341

New failing tests:
fast/events/ondrop-text-html.html

Comment 22 EWS Watchlist 2018-05-22 04:22:46 PDT

Created attachment 340971 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 23 EWS Watchlist 2018-05-22 04:43:10 PDT

Comment on attachment 340965 [details]
Patch

Attachment 340965 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7763564

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html

Comment 24 EWS Watchlist 2018-05-22 04:43:21 PDT

Created attachment 340972 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Comment 25 Alex Christensen 2021-11-01 12:16:04 PDT

Comment on attachment 340965 [details]
Patch

This has been requesting review for more than one year.  If this is still needed, please rebase and re-request review.