Bug 179372 – [WPE][GTK] Building with ENABLE_VIDEO=OFF fails to find AudioTrack.idl

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Adrian Perez]

The error message from “generate-bindings-all.pl” is:

   AudioTrack.idl not found, but it is supplemented by /home/aperez/devel/WebKit/Source/WebCore/Modules/mediasource/AudioTrackMediaSource.idl
       at /home/aperez/devel/WebKit/Source/WebCore/bindings/scripts/preprocess-idls.pl line 164.
   Died at /home/aperez/devel/WebKit/Source/WebCore/bindings/scripts/generate-bindings-all.pl line 85.

I have not copied the command line that fails because it's humongous.
Looking at the build directory, there “AudioTrack.idl” file under
“DerivedSources/”, though of course it does exist under the “Source/”
subdirectory:

   % find cmakebuild/ -name AudioTrack.idl
   % find Source/ -name AudioTrack.idl    
   Source/WebCore/html/track/AudioTrack.idl
   %

[Adrian Perez]

We used not to build “AudioTrackMediaSource.idl” before bug 174620
was fixed. Shuffling around things in the CMake build files to only
build this when ENABLE_MEDIA_SOURCE is enabled should work. I'll
also make sure that the other additional added for building in
r222205 don't break building with ENABLE_VIDEO=OFF.

[Adrian Perez]

Created attachment 326206 [details]
Patch

[Adrian Perez]

(In reply to Adrian Perez from comment #2)
> Created attachment 326206 [details]
> Patch

I tested building with all the possible combinations of ENABLE_VIDEO,
ENABLE_VIDEO_TRACK, and ENABLE_MEDIA_SOURCE — all worked fine with the
patch applied =)

[Michael Catanzaro]

Comment on attachment 326206 [details]
Patch

r=me. You can set cq+ yourself if EWS likes it (or if any EWS failures are unrelated).

[Build Bot]

Comment on attachment 326206 [details]
Patch

Attachment 326206 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5134142

New failing tests:
http/tests/workers/service/service-worker-clear.html

[Build Bot]

Created attachment 326209 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Adrian Perez]

Comment on attachment 326206 [details]
Patch

The ios-sim EWS failure seems unrelated — there has been today other
failures in Service Workers tests. I'm marking this with cq+ and I'll
keep an eye on the bots just in case.

[WebKit Commit Bot]

Comment on attachment 326206 [details]
Patch

Clearing flags on attachment: 326206

Committed r224533: <https://trac.webkit.org/changeset/224533>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/35567062>

[Timothy Hatcher]

*** Bug 180948 has been marked as a duplicate of this bug. ***