Summary: | ServiceWorkerContainer should take a PendingActivity while a service worker job is pending | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | beidson, ggaren, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=179302 | ||||||
Attachments: |
|
Description
Chris Dumez
2017-11-06 08:46:38 PST
Created attachment 326123 [details]
Patch
Comment on attachment 326123 [details]
Patch
The usual style would probably be to have scheduleJob take a completion handler so that we can ensure to have setpending/unsetpending close one to the other or use makePendingActivity.
Given m_jobMap is only used to add/remove jobs, it could probably be moved at a different level as well.
Comment on attachment 326123 [details] Patch Clearing flags on attachment: 326123 Committed r224496: <https://trac.webkit.org/changeset/224496> All reviewed patches have been landed. Closing bug. |