|
Description
Antoine Quint
2017-11-03 02:01:58 PDT
Created attachment 326027 [details]
Patch
Comment on attachment 326027 [details] Patch Attachment 326027 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5104402 New failing tests: http/wpt/web-animations/timing-model/animations/current-time.html http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html Created attachment 326028 [details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 326027 [details] Patch Attachment 326027 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5104422 New failing tests: http/wpt/web-animations/timing-model/animations/current-time.html http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html Created attachment 326029 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 326027 [details] Patch Attachment 326027 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5104423 New failing tests: http/wpt/web-animations/timing-model/animations/current-time.html http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html Created attachment 326030 [details]
Archive of layout-test-results from ews116 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 326027 [details] Patch Attachment 326027 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5104441 New failing tests: http/wpt/web-animations/timing-model/animations/current-time.html http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html Created attachment 326031 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 326032 [details]
Patch
Comment on attachment 326032 [details] Patch Attachment 326032 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5106526 New failing tests: http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html Created attachment 326037 [details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 326032 [details] Patch Attachment 326032 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5106569 New failing tests: http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html Created attachment 326039 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 326032 [details] Patch Attachment 326032 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5106663 New failing tests: http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html Created attachment 326040 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 326032 [details] Patch Attachment 326032 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5106644 New failing tests: http/wpt/web-animations/interfaces/AnimationTimeline/document-timeline.html http/wpt/web-animations/timing-model/animations/set-the-animation-start-time.html Created attachment 326041 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 326044 [details]
Patch
Created attachment 326065 [details]
Patch
Created attachment 326066 [details]
Patch
Created attachment 326067 [details]
Patch
Comment on attachment 326067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=326067&action=review > Source/WebCore/animation/DocumentTimeline.cpp:141 > + // whihc will be addressed by the refactor tracked by webkit.org/b/179293. typo which > Source/WebCore/animation/DocumentTimeline.cpp:163 > +void DocumentTimeline::windowScreenDidChange(PlatformDisplayID displayID) > +{ > +#if USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) You could leave out this function completely if !USE(RAF_D_M) > Source/WebCore/animation/DocumentTimeline.h:65 > + Document* m_document; Why does this need to be a pointer? You get a Document& in the constructor. Maybe have this as a Ref<Document> in both places. Committed r224472: <https://trac.webkit.org/changeset/224472> |