Bug 179178

Summary:

Include 'video/*' in image request Accept header if browser supports video media in image contexts.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

Images

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, colin, commit-queue, ews-watchlist, jlewis3, rniwa, webkit-bug-importer, yoav

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=181008

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none
Patch	none
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Archive of layout-test-results from ews114 for mac-elcapitan	none
Patch for landing	none
Patch for landing	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews115 for mac-elcapitan	none
Patch for landing	none
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Patch for landing	none
Patch for landing	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews115 for mac-elcapitan	none
Patch for landing	none
Patch for landing	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Patch for landing	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews114 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Patch for landing	none

Jer Noble

Reported 2017-11-02 09:11:52 PDT

Include 'video/*' in image request Accept header if browser supports video media in image contexts.

Attachments
Patch (11.51 KB, patch) 2017-11-02 09:15 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.76 MB, application/zip) 2017-11-02 10:23 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews102 for mac-elcapitan (1.20 MB, application/zip) 2017-11-02 10:29 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (1.03 MB, application/zip) 2017-11-02 10:38 PDT, Build Bot	no flags	Details
Patch (13.21 KB, patch) 2017-11-02 10:50 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (13.19 KB, patch) 2017-11-02 11:37 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.05 MB, application/zip) 2017-11-02 12:36 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.64 MB, application/zip) 2017-11-02 12:54 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.10 MB, application/zip) 2017-11-02 12:59 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.88 MB, application/zip) 2017-11-02 13:00 PDT, Build Bot	no flags	Details
Patch for landing (25.71 KB, patch) 2017-11-02 23:51 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (25.64 KB, patch) 2017-11-03 08:30 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1009.43 KB, application/zip) 2017-11-03 09:27 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.20 MB, application/zip) 2017-11-03 09:33 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.79 MB, application/zip) 2017-11-03 09:54 PDT, Build Bot	no flags	Details
Patch for landing (13.91 KB, patch) 2017-11-03 10:18 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.09 MB, application/zip) 2017-11-03 11:05 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.22 MB, application/zip) 2017-11-03 11:18 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-elcapitan (1.82 MB, application/zip) 2017-11-03 11:38 PDT, Build Bot	no flags	Details
Patch for landing (26.55 KB, patch) 2017-11-03 14:42 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (36.10 KB, patch) 2017-11-03 15:32 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.09 MB, application/zip) 2017-11-03 16:15 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.70 MB, application/zip) 2017-11-03 16:24 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.78 MB, application/zip) 2017-11-03 17:01 PDT, Build Bot	no flags	Details
Patch for landing (37.03 KB, patch) 2017-11-09 10:25 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch for landing (37.94 KB, patch) 2017-12-02 09:24 PST, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (2.25 MB, application/zip) 2017-12-02 10:05 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (2.58 MB, application/zip) 2017-12-02 10:34 PST, EWS Watchlist	no flags	Details
Patch for landing (38.78 KB, patch) 2017-12-02 10:43 PST, Jer Noble	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (2.14 MB, application/zip) 2017-12-02 11:39 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews114 for mac-elcapitan (2.88 MB, application/zip) 2017-12-02 12:07 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (2.90 MB, application/zip) 2017-12-02 12:49 PST, EWS Watchlist	no flags	Details
Patch for landing (28.57 KB, patch) 2017-12-03 20:52 PST, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (29) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2017-11-02 09:15:57 PDT

Created attachment 325717 [details] Patch

Radar WebKit Bug Importer

Comment 2 2017-11-02 09:17:17 PDT

<rdar://problem/35315768>

Build Bot

Comment 3 2017-11-02 10:23:30 PDT Comment hidden (obsolete)

Comment on attachment 325717 [details] Patch Attachment 325717 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5077139 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2017-11-02 10:23:31 PDT Comment hidden (obsolete)

Created attachment 325730 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-11-02 10:29:37 PDT Comment hidden (obsolete)

Comment on attachment 325717 [details] Patch Attachment 325717 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5077157 New failing tests: media/video-controls-in-media-document.html webarchive/loading/video-in-webarchive.html media/modern-media-controls/media-documents/media-document-invalid.html fast/replaced/table-percent-height.html security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html fast/events/media-focus-in-standalone-media-document.html media/media-document-audio-size.html media/media-document-audio-controls-visible.html http/tests/misc/mask-image-accept.html http/tests/media/media-document-referer.html media/video-document-types.html http/tests/misc/image-checks-for-accept.html media/media-document-audio-repaint.html media/modern-media-controls/media-documents/click-on-video-should-not-pause.html security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html security/contentSecurityPolicy/plugins-types-blocks-youtube-plugin-replacement-without-mime-type.html http/tests/media/media-document.html security/contentSecurityPolicy/object-src-none-blocks-quicktime-plugin-replacement.html media/modern-media-controls/media-documents/media-document-video-with-initial-audio-layout.html media/modern-media-controls/media-documents/media-document-video-mac-sizing.html media/audio-controls-timeline-in-media-document.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement.html media/video-click-dblckick-standalone.html

Build Bot

Comment 6 2017-11-02 10:29:39 PDT Comment hidden (obsolete)

Created attachment 325731 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-11-02 10:38:33 PDT Comment hidden (obsolete)

Comment on attachment 325717 [details] Patch Attachment 325717 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5077149 New failing tests: http/tests/images/image-supports-video.html

Build Bot

Comment 8 2017-11-02 10:38:34 PDT Comment hidden (obsolete)

Created attachment 325732 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Jer Noble

Comment 9 2017-11-02 10:50:13 PDT

Created attachment 325735 [details] Patch

Jer Noble

Comment 10 2017-11-02 11:37:24 PDT

Created attachment 325737 [details] Patch

Build Bot

Comment 11 2017-11-02 12:36:41 PDT Comment hidden (obsolete)

Comment on attachment 325737 [details] Patch Attachment 325737 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5078726 New failing tests: security/contentSecurityPolicy/object-src-none-blocks-quicktime-plugin-replacement.html http/tests/misc/mask-image-accept.html security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html fast/replaced/table-percent-height.html security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html http/tests/misc/image-checks-for-accept.html

Build Bot

Comment 12 2017-11-02 12:36:43 PDT Comment hidden (obsolete)

Created attachment 325748 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 13 2017-11-02 12:54:28 PDT Comment hidden (obsolete)

Comment on attachment 325737 [details] Patch Attachment 325737 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5078829 New failing tests: fast/replaced/replaced-breaking.html security/contentSecurityPolicy/object-src-none-blocks-quicktime-plugin-replacement.html http/tests/misc/mask-image-accept.html security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html fast/replaced/table-percent-height.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html http/tests/misc/image-checks-for-accept.html

Build Bot

Comment 14 2017-11-02 12:54:29 PDT Comment hidden (obsolete)

Created attachment 325752 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 15 2017-11-02 12:59:50 PDT Comment hidden (obsolete)

Comment on attachment 325737 [details] Patch Attachment 325737 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5078811 New failing tests: http/tests/images/image-supports-video.html

Build Bot

Comment 16 2017-11-02 12:59:51 PDT Comment hidden (obsolete)

Created attachment 325754 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Build Bot

Comment 17 2017-11-02 13:00:37 PDT Comment hidden (obsolete)

Comment on attachment 325737 [details] Patch Attachment 325737 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5078799 New failing tests: security/contentSecurityPolicy/object-src-none-blocks-quicktime-plugin-replacement.html http/tests/misc/mask-image-accept.html security/contentSecurityPolicy/plugins-types-allows-quicktime-plugin-replacement.html fast/replaced/table-percent-height.html security/contentSecurityPolicy/object-src-none-blocks-youtube-plugin-replacement.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement.html security/contentSecurityPolicy/plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html http/tests/misc/image-checks-for-accept.html

Build Bot

Comment 18 2017-11-02 13:00:38 PDT Comment hidden (obsolete)

Created attachment 325756 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Alex Christensen

Comment 19 2017-11-02 13:01:51 PDT

Comment on attachment 325737 [details] Patch I'm ok with the accept header, but it looks like your "drive-by fix" caused some issues. Please fix before landing.

Jer Noble

Comment 20 2017-11-02 23:51:40 PDT

Created attachment 325867 [details] Patch for landing

Jer Noble

Comment 21 2017-11-03 08:30:30 PDT

Created attachment 325898 [details] Patch for landing

Build Bot

Comment 22 2017-11-03 09:27:20 PDT Comment hidden (obsolete)

Comment on attachment 325898 [details] Patch for landing Attachment 325898 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5091037 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

Build Bot

Comment 23 2017-11-03 09:27:21 PDT Comment hidden (obsolete)

Created attachment 325903 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 24 2017-11-03 09:33:34 PDT Comment hidden (obsolete)

Comment on attachment 325898 [details] Patch for landing Attachment 325898 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5091051 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

Build Bot

Comment 25 2017-11-03 09:33:35 PDT Comment hidden (obsolete)

Created attachment 325904 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 26 2017-11-03 09:54:02 PDT Comment hidden (obsolete)

Comment on attachment 325898 [details] Patch for landing Attachment 325898 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5091163 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

Build Bot

Comment 27 2017-11-03 09:54:03 PDT Comment hidden (obsolete)

Created attachment 325909 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Jer Noble

Comment 28 2017-11-03 10:18:05 PDT

Created attachment 325910 [details] Patch for landing

Build Bot

Comment 29 2017-11-03 11:05:00 PDT Comment hidden (obsolete)

Comment on attachment 325910 [details] Patch for landing Attachment 325910 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5092205 New failing tests: http/tests/images/image-supports-video.html

Build Bot

Comment 30 2017-11-03 11:05:02 PDT Comment hidden (obsolete)

Created attachment 325917 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 31 2017-11-03 11:18:45 PDT Comment hidden (obsolete)

Comment on attachment 325910 [details] Patch for landing Attachment 325910 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5092368 New failing tests: http/tests/images/image-supports-video.html

Build Bot

Comment 32 2017-11-03 11:18:47 PDT Comment hidden (obsolete)

Created attachment 325919 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 33 2017-11-03 11:38:24 PDT Comment hidden (obsolete)

Comment on attachment 325910 [details] Patch for landing Attachment 325910 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5092418 New failing tests: http/tests/images/image-supports-video.html

Build Bot

Comment 34 2017-11-03 11:38:25 PDT Comment hidden (obsolete)

Created attachment 325926 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Jer Noble

Comment 35 2017-11-03 14:42:14 PDT

Created attachment 325963 [details] Patch for landing

Jer Noble

Comment 36 2017-11-03 15:32:57 PDT

Created attachment 325973 [details] Patch for landing

Build Bot

Comment 37 2017-11-03 16:15:19 PDT Comment hidden (obsolete)

Comment on attachment 325973 [details] Patch for landing Attachment 325973 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5096757 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

Build Bot

Comment 38 2017-11-03 16:15:21 PDT Comment hidden (obsolete)

Created attachment 325983 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 39 2017-11-03 16:24:03 PDT Comment hidden (obsolete)

Comment on attachment 325973 [details] Patch for landing Attachment 325973 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5096888 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

Build Bot

Comment 40 2017-11-03 16:24:04 PDT Comment hidden (obsolete)

Created attachment 325985 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 41 2017-11-03 17:01:26 PDT Comment hidden (obsolete)

Comment on attachment 325973 [details] Patch for landing Attachment 325973 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5097590 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

Build Bot

Comment 42 2017-11-03 17:01:27 PDT Comment hidden (obsolete)

Created attachment 325990 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Jer Noble

Comment 43 2017-11-09 10:25:44 PST

Created attachment 326464 [details] Patch for landing

Jer Noble

Comment 44 2017-12-02 09:24:49 PST

Created attachment 328234 [details] Patch for landing

EWS Watchlist

Comment 45 2017-12-02 10:05:31 PST Comment hidden (obsolete)

Comment on attachment 328234 [details] Patch for landing Attachment 328234 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5467768 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

EWS Watchlist

Comment 46 2017-12-02 10:05:32 PST Comment hidden (obsolete)

Created attachment 328237 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 47 2017-12-02 10:33:58 PST Comment hidden (obsolete)

Comment on attachment 328234 [details] Patch for landing Attachment 328234 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5467867 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

EWS Watchlist

Comment 48 2017-12-02 10:34:00 PST Comment hidden (obsolete)

Created attachment 328238 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Jer Noble

Comment 49 2017-12-02 10:43:09 PST

Created attachment 328240 [details] Patch for landing

EWS Watchlist

Comment 50 2017-12-02 11:39:37 PST

Comment on attachment 328240 [details] Patch for landing Attachment 328240 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5468376 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

EWS Watchlist

Comment 51 2017-12-02 11:39:39 PST

Created attachment 328244 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 52 2017-12-02 12:07:40 PST

Comment on attachment 328240 [details] Patch for landing Attachment 328240 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5468418 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

EWS Watchlist

Comment 53 2017-12-02 12:07:42 PST

Created attachment 328246 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

EWS Watchlist

Comment 54 2017-12-02 12:49:23 PST

Comment on attachment 328240 [details] Patch for landing Attachment 328240 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5468828 New failing tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set.html

EWS Watchlist

Comment 55 2017-12-02 12:49:25 PST

Created attachment 328249 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Jer Noble

Comment 56 2017-12-03 20:52:26 PST

Created attachment 328326 [details] Patch for landing

WebKit Commit Bot

Comment 57 2017-12-04 00:49:29 PST

Comment on attachment 328326 [details] Patch for landing Clearing flags on attachment: 328326 Committed r225472: <https://trac.webkit.org/changeset/225472>

WebKit Commit Bot

Comment 58 2017-12-04 00:49:32 PST

All reviewed patches have been landed. Closing bug.

Matt Lewis

Comment 59 2017-12-19 14:56:57 PST

The test added in this patch is extremely flaky on macOS Sierra and High Sierra WK1: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fimages%2Fimage-supports-video.html https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r226129%20(5383)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/5383 diff: --- /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/http/tests/images/image-supports-video-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk1/build/layout-test-results/http/tests/images/image-supports-video-actual.txt @@ -1,2 +1,2 @@ -PASS: video source selected. +FAIL: <img> threw error.

Note You need to log in before you can comment on or make changes to this bug.