| Summary: | [Settings] Generate more of the WebKit preferences code | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, darin, dbates, ggaren, joepeck, rniwa, simon.fraser, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 178637 | ||||||||
| Attachments: |
|
||||||||
|
Description
Sam Weinig
2017-10-27 10:33:00 PDT
Created attachment 325181 [details]
Patch
Created attachment 325207 [details]
Patch
Comment on attachment 325207 [details]
Patch
For what it's worth, I really hate that we're using Ruby instead of Python for this. This does against our efforts to move everything to Python and have a single language for our scripts. A lot of people do not know Ruby.
(In reply to Chris Dumez from comment #3) > Comment on attachment 325207 [details] > Patch > > For what it's worth, I really hate that we're using Ruby instead of Python > for this. This does against our efforts to move everything to Python and > have a single language for our scripts. A lot of people do not know Ruby. *goes* against (In reply to Chris Dumez from comment #3) > Comment on attachment 325207 [details] > Patch > > For what it's worth, I really hate that we're using Ruby instead of Python > for this. This does against our efforts to move everything to Python and > have a single language for our scripts. A lot of people do not know Ruby. I wasn't aware we had an effort to converge on a single scripting language (e.g. I have made no attempt to migrate the bindings generator to python nor has anyone else as far as I know). I have always gone with use the right tool for the job, and in this case, I wanted a templating library, which ruby has built in by way of ERB. Comment on attachment 325207 [details] Patch Rejecting attachment 325207 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 325207, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/5024589 Committed r224154: <https://trac.webkit.org/changeset/224154> (In reply to WebKit Commit Bot from comment #6) > Comment on attachment 325207 [details] > Patch > > Rejecting attachment 325207 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', > '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', > 'validate-changelog', '--check-oops', '--non-interactive', 325207, > '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit > > /Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid > reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case > insensitive). > > Full output: http://webkit-queues.webkit.org/results/5024589 I don't get why this is happening. I feel like the commit queue used to be able to fill in the Reviewed by part. :\
> I don't get why this is happening. I feel like the commit queue used to be
> able to fill in the Reviewed by part. :\
I think it’s looking for an OOPS line to fill in which is missing.
(In reply to Joseph Pecoraro from comment #9) > > I don't get why this is happening. I feel like the commit queue used to be > > able to fill in the Reviewed by part. :\ > > I think it’s looking for an OOPS line to fill in which is missing. Weird. Why did I remove that! |