Bug 178898

Summary: [WPE] Upstream or stop using cairo-egl-device-create-for-egl-surface.patch
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WPE WebKitAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, commit-queue, mcatanzaro, olivier.blin, webkit-bug-importer, zan
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 178894    
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2017-10-26 16:55:21 PDT
We currently have Tools/wpe/patches/cairo-egl-device-create-for-egl-surface.patch. We need to either upstream that patch and wait patiently for the next cairo release, or else find a way to not require it, since we surely don't want to create a release that won't actually build on any platforms. I've done a bit of grepping and I think it may be completely unused, so this might be an easy problem to resolve.
Attachments
Patch (6.39 KB, patch)
2017-10-26 17:44 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-10-26 17:40:34 PDT
I didn't do a clean build, but reran update-webkitwpe-libs and rebuilt WPE, and it builds just fine without the patch. Let's get rid of it and see if anything breaks. But I guess it's only needed downstream or something.
Michael Catanzaro
Comment 2 2017-10-26 17:44:50 PDT
Created attachment 325088 [details] Patch
Adrian Perez
Comment 3 2017-10-27 01:35:37 PDT
Comment on attachment 325088 [details] Patch r+ (informal) Same opinion here, and I also checked that building without the patch seems to work fine.
WebKit Commit Bot
Comment 4 2017-10-30 11:14:03 PDT
Comment on attachment 325088 [details] Patch Clearing flags on attachment: 325088 Committed r224190: <https://trac.webkit.org/changeset/224190>
WebKit Commit Bot
Comment 5 2017-10-30 11:14:04 PDT
All reviewed patches have been landed. Closing bug.
Olivier Blin
Comment 6 2017-11-07 07:38:49 PST
For reference, usage of cairo_egl_device_create_for_egl_surface() has been removed in this commit (March 2017) downstream: https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/8bd19fc8035813f1b7334d7ff716e85d9091c65c
Note You need to log in before you can comment on or make changes to this bug.