Summary: | [Service Worker] Add stubs for serviceWorkerClient.type | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | beidson, ggaren, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=174541 | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 178794, 178816 | ||||||||||||
Attachments: |
|
Description
Chris Dumez
2017-10-25 10:38:36 PDT
Created attachment 324846 [details]
Patch
Created attachment 324851 [details]
Patch
Please note, neither chrome or firefox has removed FrameType. It might get added back. See: https://github.com/w3c/ServiceWorker/issues/732#issuecomment-291056364 Comment on attachment 324846 [details]
Patch
Ok, will keep frameType for now. Just add type.
Created attachment 324855 [details]
Patch
Comment on attachment 324855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324855&action=review > Source/WebCore/ChangeLog:9 > + - ttps://w3c.github.io/ServiceWorker/#enumdef-clienttype s//ttps/https > Source/WebCore/ChangeLog:19 > + * workers/service/ServiceWorkerClientType.h: Copied from Source/WebCore/workers/service/ServiceWorkerClient.idl. Added > Source/WebCore/WebCore.xcodeproj/project.pbxproj:2924 > + 8369FDFC1FA102E300C1FF1F /* ServiceWorkerClientType.h in Headers */ = {isa = PBXBuildFile; fileRef = 8369FDFB1FA102CB00C1FF1F /* ServiceWorkerClientType.h */; }; Shouldn't there also be some JSServiceWorkerClientType. files added? Created attachment 324862 [details]
Patch
Comment on attachment 324862 [details] Patch Clearing flags on attachment: 324862 Committed r223973: <https://trac.webkit.org/changeset/223973> All reviewed patches have been landed. Closing bug. |