Bug 178812

Summary:

[Service Worker] Add stubs for serviceWorkerClient.type

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, ggaren, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=174541

Bug Depends on:

Bug Blocks:

178794, 178816

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2017-10-25 10:38:36 PDT

Replace FrameType with ClientType to match the latest specification: - https://w3c.github.io/ServiceWorker/#enumdef-clienttype

Attachments
Patch (14.85 KB, patch) 2017-10-25 10:40 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (11.21 KB, text/plain) 2017-10-25 11:10 PDT, Chris Dumez	no flags	Details
Patch (14.64 KB, patch) 2017-10-25 11:25 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (16.69 KB, patch) 2017-10-25 12:08 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-10-25 10:40:20 PDT

Created attachment 324846 [details] Patch

Chris Dumez

Comment 2 2017-10-25 11:10:48 PDT

Created attachment 324851 [details] Patch

Ben Kelly

Comment 3 2017-10-25 11:12:49 PDT

Please note, neither chrome or firefox has removed FrameType. It might get added back. See: https://github.com/w3c/ServiceWorker/issues/732#issuecomment-291056364

Chris Dumez

Comment 4 2017-10-25 11:19:19 PDT

Comment on attachment 324846 [details] Patch Ok, will keep frameType for now. Just add type.

Chris Dumez

Comment 5 2017-10-25 11:25:43 PDT

Created attachment 324855 [details] Patch

youenn fablet

Comment 6 2017-10-25 11:45:40 PDT

Comment on attachment 324855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324855&action=review > Source/WebCore/ChangeLog:9 > + - ttps://w3c.github.io/ServiceWorker/#enumdef-clienttype s//ttps/https > Source/WebCore/ChangeLog:19 > + * workers/service/ServiceWorkerClientType.h: Copied from Source/WebCore/workers/service/ServiceWorkerClient.idl. Added > Source/WebCore/WebCore.xcodeproj/project.pbxproj:2924 > + 8369FDFC1FA102E300C1FF1F /* ServiceWorkerClientType.h in Headers */ = {isa = PBXBuildFile; fileRef = 8369FDFB1FA102CB00C1FF1F /* ServiceWorkerClientType.h */; }; Shouldn't there also be some JSServiceWorkerClientType. files added?

Chris Dumez

Comment 7 2017-10-25 12:08:25 PDT

Created attachment 324862 [details] Patch

Chris Dumez

Comment 8 2017-10-25 12:36:13 PDT

Comment on attachment 324862 [details] Patch Clearing flags on attachment: 324862 Committed r223973: <https://trac.webkit.org/changeset/223973>

Chris Dumez

Comment 9 2017-10-25 12:36:15 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2017-11-15 12:51:07 PST

<rdar://problem/35568284>

Note You need to log in before you can comment on or make changes to this bug.