Bug 178671

Summary:

Add tests to ensure spelling error dots are drawn in the correct place in bottom-to-top and right-to-left writing modes

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

jlewis3, lforschler, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

178232, 178759

Attachments:

Description	Flags
Layout tests	none

Daniel Bates

Reported 2017-10-23 10:47:30 PDT

Add tests to ensure spelling error dots are drawn in the correct place in bottom-to-top and right-to-left writing modes.

Attachments
Layout tests (7.47 KB, patch) 2017-10-23 10:52 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2017-10-23 10:52:29 PDT

Created attachment 324565 [details] Layout tests

Daniel Bates

Comment 2 2017-10-23 11:10:20 PDT

Comment on attachment 324565 [details] Layout tests Clearing flags on attachment: 324565 Committed r223845: <https://trac.webkit.org/changeset/223845>

Daniel Bates

Comment 3 2017-10-23 11:10:21 PDT

All reviewed patches have been landed. Closing bug.

Matt Lewis

Comment 4 2017-10-24 13:34:48 PDT

These test are also flaky image only failures on WK1 as well. Should these be marked like the mac-wk2 tests? https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fwriting-mode%2Fenglish-bt-text-with-spelling-marker.html https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r223908%20(5545)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/5545

Radar WebKit Bug Importer

Comment 5 2017-11-15 12:52:13 PST

<rdar://problem/35568313>

Note You need to log in before you can comment on or make changes to this bug.