Bug 178642

Summary: stress/check-string-ident.js is improperly skipped
Product: WebKit Reporter: Zan Dobersek <zan>
Component: JavaScriptCoreAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, mark.lam, ryanhaddad, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645    
Attachments:
Description Flags
Patch none

Description Zan Dobersek 2017-10-22 02:12:25 PDT
The stress/check-string-ident.js was added in r207017:
https://trac.webkit.org/changeset/207017/webkit

It was later skipped in r208205:
https://trac.webkit.org/changeset/208205/webkit

It's still flaky, with the number of DFG compiles varying across different runs.

It's not properly skipped though -- while the skip directive is used in the JS file, the following defaultNoEagerRun directive still sets up the test to run as if the skipping wasn't done.
Comment 1 Zan Dobersek 2017-10-22 02:15:56 PDT
Created attachment 324523 [details]
Patch
Comment 2 Zan Dobersek 2017-10-22 02:19:57 PDT
Comment on attachment 324523 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324523&action=review

> JSTests/stress/check-string-ident.js:-2
> +// Skipped due to flakiness, used defaultNoEagerRun before.
>  //@ skip
> -//@ defaultNoEagerRun

This enforces skipping on all platforms (as it was probably intended), but I've only seen the test fail on ARM platforms.
Comment 3 Zan Dobersek 2017-10-22 22:27:31 PDT
Comment on attachment 324523 [details]
Patch

Clearing flags on attachment: 324523

Committed r223832: <https://trac.webkit.org/changeset/223832>
Comment 4 Zan Dobersek 2017-10-22 22:27:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-11-15 13:11:23 PST
<rdar://problem/35568948>