Bug 178642

Summary: stress/check-string-ident.js is improperly skipped
Product: WebKit Reporter: Zan Dobersek <zan>
Component: JavaScriptCoreAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, mark.lam, ryanhaddad, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2017-10-22 02:12:25 PDT
The stress/check-string-ident.js was added in r207017: https://trac.webkit.org/changeset/207017/webkit It was later skipped in r208205: https://trac.webkit.org/changeset/208205/webkit It's still flaky, with the number of DFG compiles varying across different runs. It's not properly skipped though -- while the skip directive is used in the JS file, the following defaultNoEagerRun directive still sets up the test to run as if the skipping wasn't done.
Attachments
Patch (1.16 KB, patch)
2017-10-22 02:15 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-10-22 02:15:56 PDT
Created attachment 324523 [details] Patch
Zan Dobersek
Comment 2 2017-10-22 02:19:57 PDT
Comment on attachment 324523 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324523&action=review > JSTests/stress/check-string-ident.js:-2 > +// Skipped due to flakiness, used defaultNoEagerRun before. > //@ skip > -//@ defaultNoEagerRun This enforces skipping on all platforms (as it was probably intended), but I've only seen the test fail on ARM platforms.
Zan Dobersek
Comment 3 2017-10-22 22:27:31 PDT
Comment on attachment 324523 [details] Patch Clearing flags on attachment: 324523 Committed r223832: <https://trac.webkit.org/changeset/223832>
Zan Dobersek
Comment 4 2017-10-22 22:27:35 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-11-15 13:11:23 PST
<rdar://problem/35568948>
Note You need to log in before you can comment on or make changes to this bug.