|Summary:||Add tests to ensure spelling error dots are drawn in the correct place for overlapping lines|
|Product:||WebKit||Reporter:||Daniel Bates <dbates>|
|Component:||Tools / Tests||Assignee:||Daniel Bates <dbates>|
|Severity:||Normal||CC:||bfulgham, koivisto, lforschler, simon.fraser, webkit-bug-importer, zalan|
|Version:||WebKit Nightly Build|
|Bug Depends on:|
Description Daniel Bates 2017-10-20 17:03:30 PDT
Spelling error dots drawn in wrong place for overlapping lines.
Comment 1 Daniel Bates 2017-10-20 17:05:29 PDT
Created attachment 324471 [details] [Screenshot] Expected (shipping Safari on macOS Sierra) Disregarding the orientation of the dots (this was fixed in bug #176949), this screenshot represents the expected position for the dots.
Comment 2 Daniel Bates 2017-10-20 17:06:09 PDT
Created attachment 324472 [details] [Screenshot] Bug Screenshot following r223699.
Comment 5 Daniel Bates 2017-10-20 17:33:03 PDT
Created attachment 324477 [details] Patch and layout tests
Comment 6 Daniel Bates 2017-10-23 10:41:48 PDT
As it turns outs I decided to revert r223699 in <https://trac.webkit.org/changeset/223840> because it causes regressions in addition to the one reported in this bug. I will incorporate the source code changes from the patch on this bug (attachment #324477 [details]) into an updated patch for bug #178232. I am re-purposing this bug to land the layout tests included in attachment #324477 [details]. This will ensure that we do not regress painting of spelling dots in overlapping lines.