| Summary: | Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
| Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, buildbot, darin, sam, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 124391 | ||||||
| Attachments: |
|
||||||
|
Description
Ryosuke Niwa
2017-10-10 19:49:03 PDT
Created attachment 323375 [details]
Patch
Attachment 323375 [details] did not pass style-queue:
ERROR: Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:195: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 323375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323375&action=review > Source/WebCore/platform/cocoa/PasteboardCocoa.mm:198 > + if (existingMIMEs.contains(mimeType)) Nice catch! > Source/WebKit/ChangeLog:8 > + Plumed customPasteboardDataEnabled flag to be used in WebKitTestRunner. *Plumbed Thanks for the review! (In reply to Wenson Hsieh from comment #3) > Comment on attachment 323375 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=323375&action=review > > > Source/WebCore/platform/cocoa/PasteboardCocoa.mm:198 > > + if (existingMIMEs.contains(mimeType)) > > Nice catch! > > > Source/WebKit/ChangeLog:8 > > + Plumed customPasteboardDataEnabled flag to be used in WebKitTestRunner. > > *Plumbed Will fix. Committed r223167: <http://trac.webkit.org/changeset/223167> |