Bug 178154

Summary: Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, darin, sam, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124391    
Attachments:
Description Flags
Patch wenson_hsieh: review+

Description Ryosuke Niwa 2017-10-10 19:49:03 PDT
Enable custom pasteboard on macOS and iOS inside DumpRenderTree and WebKitTestRunner
so that we can test the shipping configuration in Safari in our tests.
Comment 1 Ryosuke Niwa 2017-10-10 20:12:16 PDT
Created attachment 323375 [details]
Patch
Comment 2 Build Bot 2017-10-10 20:14:36 PDT
Attachment 323375 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.mm:195:  The parameter name "data" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Wenson Hsieh 2017-10-10 20:50:46 PDT
Comment on attachment 323375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323375&action=review

> Source/WebCore/platform/cocoa/PasteboardCocoa.mm:198
> +        if (existingMIMEs.contains(mimeType))

Nice catch!

> Source/WebKit/ChangeLog:8
> +        Plumed customPasteboardDataEnabled flag to be used in WebKitTestRunner.

*Plumbed
Comment 4 Ryosuke Niwa 2017-10-10 21:10:11 PDT
Thanks for the review!

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 323375 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=323375&action=review
> 
> > Source/WebCore/platform/cocoa/PasteboardCocoa.mm:198
> > +        if (existingMIMEs.contains(mimeType))
> 
> Nice catch!
> 
> > Source/WebKit/ChangeLog:8
> > +        Plumed customPasteboardDataEnabled flag to be used in WebKitTestRunner.
> 
> *Plumbed

Will fix.
Comment 5 Ryosuke Niwa 2017-10-10 21:12:32 PDT
Committed r223167: <http://trac.webkit.org/changeset/223167>
Comment 6 Radar WebKit Bug Importer 2017-10-10 21:13:16 PDT
<rdar://problem/34926645>