Bug 178118

Summary: Loading should be disabled while constructing the fragment in WebContentReader::readWebArchive
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, cdumez, darin, koivisto, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124391    
Attachments:
Description Flags
Cleanup
none
Fixed builds
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Skip the drag & drop test on iOS koivisto: review+

Ryosuke Niwa
Reported 2017-10-10 01:25:04 PDT
This cleanup is needed in order to start using blob URLs instead of overriding document loaders.
Attachments
Cleanup (13.31 KB, patch)
2017-10-10 01:34 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed builds (13.42 KB, patch)
2017-10-10 02:00 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (4.02 MB, application/zip)
2017-10-10 03:35 PDT, Build Bot 		no flags
Details
Skip the drag & drop test on iOS (14.07 KB, patch)
2017-10-10 11:31 PDT, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-10-10 01:34:27 PDT
Created attachment 323288 [details] Cleanup
Ryosuke Niwa
Comment 2 2017-10-10 01:35:04 PDT
This patch should improve the reliability of some of these editing tests.
Ryosuke Niwa
Comment 3 2017-10-10 02:00:49 PDT
Created attachment 323290 [details] Fixed builds
Build Bot
Comment 4 2017-10-10 03:35:41 PDT
Comment on attachment 323290 [details] Fixed builds Attachment 323290 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4810684 New failing tests: editing/selection/drag-to-contenteditable-iframe.html
Build Bot
Comment 5 2017-10-10 03:35:43 PDT
Created attachment 323296 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Ryosuke Niwa
Comment 6 2017-10-10 11:12:55 PDT
(In reply to Build Bot from comment #4) > Comment on attachment 323290 [details] > Fixed builds > > Attachment 323290 [details] did not pass ios-sim-ews (ios-simulator-wk2): > Output: http://webkit-queues.webkit.org/results/4810684 > > New failing tests: > editing/selection/drag-to-contenteditable-iframe.html That's odd... this test is supposed to be ignored on iOS...
Ryosuke Niwa
Comment 7 2017-10-10 11:31:59 PDT
Created attachment 323325 [details] Skip the drag & drop test on iOS
Antti Koivisto
Comment 8 2017-10-10 11:42:17 PDT
Comment on attachment 323325 [details] Skip the drag & drop test on iOS r=me
Chris Dumez
Comment 9 2017-10-10 11:42:36 PDT
Comment on attachment 323325 [details] Skip the drag & drop test on iOS r=me
Alexey Proskuryakov
Comment 10 2017-10-10 13:07:56 PDT
Comment on attachment 323325 [details] Skip the drag & drop test on iOS View in context: https://bugs.webkit.org/attachment.cgi?id=323325&action=review > LayoutTests/platform/ios/TestExpectations:241 > # Drag-and-drop is not supported: > editing/pasteboard/datatransfer-items-drop-plaintext-file.html > editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html > +editing/selection/drag-to-contenteditable-iframe.html We should really have all of these marked with WontFix (or Skipped if WontFix is not true). It's mostly legacy lines that don't have any expectation spelled out.
Ryosuke Niwa
Comment 11 2017-10-10 13:39:26 PDT
(In reply to Alexey Proskuryakov from comment #10) > Comment on attachment 323325 [details] > Skip the drag & drop test on iOS > > View in context: > https://bugs.webkit.org/attachment.cgi?id=323325&action=review > > > LayoutTests/platform/ios/TestExpectations:241 > > # Drag-and-drop is not supported: > > editing/pasteboard/datatransfer-items-drop-plaintext-file.html > > editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html > > +editing/selection/drag-to-contenteditable-iframe.html > > We should really have all of these marked with WontFix (or Skipped if > WontFix is not true). It's mostly legacy lines that don't have any > expectation spelled out. Sure, I'll add [ Skip ].
Ryosuke Niwa
Comment 12 2017-10-10 13:50:24 PDT
Committed r223140: <http://trac.webkit.org/changeset/223140>
Radar WebKit Bug Importer
Comment 13 2017-10-10 13:51:24 PDT
<rdar://problem/34918607>
Note You need to log in before you can comment on or make changes to this bug.