Bug 177752

Summary:

[WPE] Do not require XSLT if disabled

Product:

WebKit

Reporter:

Olivier Blin <olivier.blin>

Component:

WPE WebKit

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, bugs-noreply, commit-queue, cturner, don.olmstead, mcatanzaro, webkit-bug-importer, zan

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=177857

Attachments:

Description	Flags
Patch	none

Description Olivier Blin 2017-10-02 10:28:09 PDT

libxslt is not a hard dep.

Comment 1 Olivier Blin 2017-10-02 10:29:46 PDT

Created attachment 322387 [details]
Patch

Comment 2 WebKit Commit Bot 2017-10-02 11:58:10 PDT

Comment on attachment 322387 [details]
Patch

Clearing flags on attachment: 322387

Committed r222727: <http://trac.webkit.org/changeset/222727>

Comment 3 WebKit Commit Bot 2017-10-02 11:58:12 PDT

All reviewed patches have been landed.  Closing bug.

Comment 4 Michael Catanzaro 2017-10-03 02:07:21 PDT

I suppose we should expose ENABLE_XSLT as a public option, since it allows avoiding a dependency that's not needed on embedded devices.

Comment 5 Zan Dobersek 2017-10-03 02:41:29 PDT

(In reply to Michael Catanzaro from comment #4)
> I suppose we should expose ENABLE_XSLT as a public option, since it allows
> avoiding a dependency that's not needed on embedded devices.

Yes, I think that makes sense.

Comment 6 Adrian Perez 2017-10-03 02:49:39 PDT

(In reply to Zan Dobersek from comment #5)
> (In reply to Michael Catanzaro from comment #4)
> > I suppose we should expose ENABLE_XSLT as a public option, since it allows
> > avoiding a dependency that's not needed on embedded devices.
> 
> Yes, I think that makes sense.

+1

Comment 7 Don Olmstead 2017-10-03 11:05:35 PDT

(In reply to Adrian Perez from comment #6)
> (In reply to Zan Dobersek from comment #5)
> > (In reply to Michael Catanzaro from comment #4)
> > > I suppose we should expose ENABLE_XSLT as a public option, since it allows
> > > avoiding a dependency that's not needed on embedded devices.
> > 
> > Yes, I think that makes sense.
> 
> +1

Please do. We want to remove libxslt from WinCairo by default

Comment 8 Michael Catanzaro 2017-10-04 02:09:37 PDT

This doesn't affect WinCairo at all since the choice of which options to expose for WPE is WPE-specific.

Comment 9 Michael Catanzaro 2017-10-04 02:11:51 PDT

Bug #177857

Comment 10 Michael Catanzaro 2017-10-04 02:12:47 PDT

In the future: please no patches to allow disabling dependencies unless the corresponding feature flag also made public.