Bug 177730

Summary: [Settings] Move remaining simple settings to Settings.in
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, dbates, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 177835    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
For landing
none
For landing
none
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2017-10-01 18:38:06 PDT
[Settings] Move remaining simple settings to Settings.in
Attachments
Patch (59.40 KB, patch)
2017-10-01 19:00 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
For landing (61.09 KB, patch)
2017-10-01 20:30 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
For landing (61.02 KB, patch)
2017-10-01 20:34 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (18.53 KB, patch)
2017-10-18 10:36 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (20.16 KB, patch)
2017-10-18 10:51 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (21.47 KB, patch)
2017-10-18 11:07 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-10-01 19:00:51 PDT
Created attachment 322341 [details] Patch
Sam Weinig
Comment 2 2017-10-01 20:30:23 PDT
Created attachment 322350 [details] For landing
Sam Weinig
Comment 3 2017-10-01 20:34:58 PDT
Created attachment 322351 [details] For landing
WebKit Commit Bot
Comment 4 2017-10-01 21:26:00 PDT
The commit-queue encountered the following flaky tests while processing attachment 322351 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2017-10-01 23:02:56 PDT
Comment on attachment 322351 [details] For landing Clearing flags on attachment: 322351 Committed r222698: <http://trac.webkit.org/changeset/222698>
WebKit Commit Bot
Comment 6 2017-10-01 23:02:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-10-01 23:04:14 PDT
<rdar://problem/34763346>
WebKit Commit Bot
Comment 8 2017-10-03 13:46:15 PDT
Re-opened since this is blocked by bug 177835
Sam Weinig
Comment 9 2017-10-18 10:36:15 PDT
Created attachment 324131 [details] Patch
Sam Weinig
Comment 10 2017-10-18 10:51:09 PDT
Created attachment 324134 [details] Patch
Daniel Bates
Comment 11 2017-10-18 10:58:53 PDT
Comment on attachment 324134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324134&action=review > Source/WebCore/ChangeLog:19 > + Migrage simple settings from SettingsBase to here. No need to rage about it. Migrage => Migrate > Source/WebCore/Scripts/GenerateSettings/Settings.py:97 > + if self.getter: > + return self.getter > return self.name return self.getter or self.name > Source/WebCore/Scripts/GenerateSettings/Settings.py:131 > + for line in open(input, 'r'): This is leaking the file handle. It is good programming practice to close the file once we no longer need it. Either we need a close() or, we can use the "with" keyword since File objects implement the context manager interface: with open(input, 'r') as file: for line in file: ... See <https://docs.python.org/2/tutorial/inputoutput.html> for more details.
Sam Weinig
Comment 12 2017-10-18 11:07:45 PDT
Created attachment 324137 [details] Patch
WebKit Commit Bot
Comment 13 2017-10-18 13:18:42 PDT
Comment on attachment 324137 [details] Patch Clearing flags on attachment: 324137 Committed r223624: <https://trac.webkit.org/changeset/223624>
WebKit Commit Bot
Comment 14 2017-10-18 13:18:43 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.