Bug 177730

Summary: [Settings] Move remaining simple settings to Settings.in
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Severity: Normal CC: commit-queue, darin, dbates, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 177835    
Bug Blocks:    
Description Flags
For landing
For landing
Patch none

Description Sam Weinig 2017-10-01 18:38:06 PDT
[Settings] Move remaining simple settings to Settings.in
Comment 1 Sam Weinig 2017-10-01 19:00:51 PDT
Created attachment 322341 [details]
Comment 2 Sam Weinig 2017-10-01 20:30:23 PDT
Created attachment 322350 [details]
For landing
Comment 3 Sam Weinig 2017-10-01 20:34:58 PDT
Created attachment 322351 [details]
For landing
Comment 4 WebKit Commit Bot 2017-10-01 21:26:00 PDT
The commit-queue encountered the following flaky tests while processing attachment 322351 [details]:

The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2017-10-01 23:02:56 PDT
Comment on attachment 322351 [details]
For landing

Clearing flags on attachment: 322351

Committed r222698: <http://trac.webkit.org/changeset/222698>
Comment 6 WebKit Commit Bot 2017-10-01 23:02:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-01 23:04:14 PDT
Comment 8 WebKit Commit Bot 2017-10-03 13:46:15 PDT
Re-opened since this is blocked by bug 177835
Comment 9 Sam Weinig 2017-10-18 10:36:15 PDT
Created attachment 324131 [details]
Comment 10 Sam Weinig 2017-10-18 10:51:09 PDT
Created attachment 324134 [details]
Comment 11 Daniel Bates 2017-10-18 10:58:53 PDT
Comment on attachment 324134 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=324134&action=review

> Source/WebCore/ChangeLog:19
> +            Migrage simple settings from SettingsBase to here.

No need to rage about it.

Migrage => Migrate

> Source/WebCore/Scripts/GenerateSettings/Settings.py:97
> +        if self.getter:
> +            return self.getter
>          return self.name

return self.getter or self.name

> Source/WebCore/Scripts/GenerateSettings/Settings.py:131
> +    for line in open(input, 'r'):

This is leaking the file handle. It is good programming practice to close the file once we no longer need it. Either we need a close() or, we can use the "with" keyword since File objects implement the context manager interface:

with open(input, 'r') as file:
    for line in file:

See <https://docs.python.org/2/tutorial/inputoutput.html> for more details.
Comment 12 Sam Weinig 2017-10-18 11:07:45 PDT
Created attachment 324137 [details]
Comment 13 WebKit Commit Bot 2017-10-18 13:18:42 PDT
Comment on attachment 324137 [details]

Clearing flags on attachment: 324137

Committed r223624: <https://trac.webkit.org/changeset/223624>
Comment 14 WebKit Commit Bot 2017-10-18 13:18:43 PDT
All reviewed patches have been landed.  Closing bug.