Bug 177727

Summary: [Settings] Enums should not be passed by const reference
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: commit-queue, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 177835    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Sam Weinig
Reported 2017-10-01 15:38:49 PDT
[Settings] Enums should not be passed by const reference
Attachments
Patch (6.45 KB, patch)
2017-10-01 15:54 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-10-01 15:54:33 PDT
Created attachment 322336 [details] Patch
WebKit Commit Bot
Comment 2 2017-10-01 20:17:22 PDT
Comment on attachment 322336 [details] Patch Clearing flags on attachment: 322336 Committed r222695: <http://trac.webkit.org/changeset/222695>
WebKit Commit Bot
Comment 3 2017-10-01 20:17:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2017-10-01 20:18:42 PDT
<rdar://problem/34762536>
WebKit Commit Bot
Comment 5 2017-10-03 13:46:14 PDT
Re-opened since this is blocked by bug 177835
Sam Weinig
Comment 6 2017-10-18 12:44:57 PDT
Re-fixed this in a different bug.
Note You need to log in before you can comment on or make changes to this bug.