Bug 177726

Summary:

Create a SPIR-V assembler

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

WebGPU

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, fpizlo, keith_miller, saam, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

176199

Attachments:

Description	Flags
WIP	none
Patch	none
Patch	none
WIP	none
Patch	fpizlo: review+

Myles C. Maxfield

Reported 2017-10-01 14:44:56 PDT

Create a SPIR-V assembler

Attachments
WIP (179.53 KB, patch) 2017-10-01 14:45 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (185.03 KB, patch) 2017-10-02 12:12 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (187.84 KB, patch) 2017-10-02 23:26 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (189.02 KB, patch) 2017-10-03 10:34 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (187.37 KB, patch) 2017-10-03 13:58 PDT, Myles C. Maxfield	fpizlo: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2017-10-01 14:45:45 PDT

Created attachment 322335 [details] WIP WIP

Myles C. Maxfield

Comment 2 2017-10-02 12:12:35 PDT

Created attachment 322408 [details] Patch Patch

Myles C. Maxfield

Comment 3 2017-10-02 23:26:11 PDT

Created attachment 322493 [details] Patch

Sam Weinig

Comment 4 2017-10-03 07:09:21 PDT

Comment on attachment 322493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322493&action=review > Tools/WebGPUShadingLanguageRI/SPIR-V.js:30 > + var xhr = new XMLHttpRequest(); > + xhr.addEventListener("load", function () { > + let json = JSON.parse(this.responseText); This can be made a bit more modern by either using fetch() with response.json (which I would recommend) or by continuing to use XHR and using xhr.responseType = "json".

Myles C. Maxfield

Comment 5 2017-10-03 10:34:15 PDT

Created attachment 322543 [details] WIP

Myles C. Maxfield

Comment 6 2017-10-03 13:58:04 PDT

Created attachment 322576 [details] Patch Patch

Filip Pizlo

Comment 7 2017-10-03 17:36:22 PDT

Comment on attachment 322576 [details] Patch rs=me

Myles C. Maxfield

Comment 8 2017-10-03 17:53:39 PDT

Committed r222825: <http://trac.webkit.org/changeset/222825>