Bug 177704

Summary: WSL should be fine with &foo()[i] if foo() returns a []
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebGPUAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: mmaxfield, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
the patch saam: review+

Filip Pizlo
Reported 2017-09-29 23:35:45 PDT
Patch forthcoming.
Attachments
the patch (11.99 KB, patch)
2017-09-30 00:28 PDT, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-09-30 00:28:48 PDT
Created attachment 322285 [details] the patch
Filip Pizlo
Comment 2 2017-09-30 00:30:54 PDT
Comment on attachment 322285 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=322285&action=review > Tools/WebGPUShadingLanguageRI/Checker.js:492 > + node.notLValueReason = "Base of property access is neither lvalue not array reference"; *nor
Saam Barati
Comment 3 2017-10-02 14:50:42 PDT
Comment on attachment 322285 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=322285&action=review > Tools/WebGPUShadingLanguageRI/PropertyAccessExpression.js:32 > + this._isLValue = null; // We use null to indicate that we don't know yet. Do you use this fact somewhere?
Filip Pizlo
Comment 4 2017-10-02 15:01:17 PDT
Landed in https://trac.webkit.org/changeset/222750/webkit
Radar WebKit Bug Importer
Comment 5 2017-10-02 15:02:50 PDT
<rdar://problem/34777663>
Myles C. Maxfield
Comment 6 2018-10-13 19:23:59 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/169
Note You need to log in before you can comment on or make changes to this bug.