Bug 177704

Summary: WSL should be fine with &foo()[i] if foo() returns a []
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebGPUAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: mmaxfield, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
the patch saam: review+

Description Filip Pizlo 2017-09-29 23:35:45 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2017-09-30 00:28:48 PDT 
Created attachment 322285 [details]
the patch
Comment 2 Filip Pizlo 2017-09-30 00:30:54 PDT 
Comment on attachment 322285 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322285&action=review

> Tools/WebGPUShadingLanguageRI/Checker.js:492
> +            node.notLValueReason = "Base of property access is neither lvalue not array reference";

*nor
Comment 3 Saam Barati 2017-10-02 14:50:42 PDT 
Comment on attachment 322285 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322285&action=review

> Tools/WebGPUShadingLanguageRI/PropertyAccessExpression.js:32
> +        this._isLValue = null; // We use null to indicate that we don't know yet.

Do you use this fact somewhere?
Comment 4 Filip Pizlo 2017-10-02 15:01:17 PDT 
Landed in https://trac.webkit.org/changeset/222750/webkit
Comment 5 Radar WebKit Bug Importer 2017-10-02 15:02:50 PDT 
<rdar://problem/34777663>
Comment 6 Myles C. Maxfield 2018-10-13 19:23:59 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/169