Bug 177634

Summary: REGRESSION(r222640) [GTK] Build broken with ATK 2.14
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WebKitGTKAssignee: Joanmarie Diggs <jdiggs>
Severity: Normal CC: aboxhall, apinheiro, bugs-noreply, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mcatanzaro, samuel_white
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 177542    
Description Flags
Patch none

Description Carlos Alberto Lopez Perez 2017-09-28 18:32:24 PDT
It seems ATK_STATE_READ_ONLY Requires ATK >= 2.16

And Debian 8 still ships 2.14, and per our dependencies policy https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy we still should support the default build there.

Build log failure:

Its not needed to make the feature work with ATK 2.14.
We only need to fix the build, so building WebKitGTK+ on Debian 8 (Jessie) can continue to be possible. 

Therefore just #ifdef'ing the code for ATK >= 2.16 is ok.
Comment 1 Joanmarie Diggs 2017-10-02 02:43:38 PDT
Created attachment 322366 [details]
Comment 2 WebKit Commit Bot 2017-10-02 05:17:27 PDT
Comment on attachment 322366 [details]

Clearing flags on attachment: 322366

Committed r222705: <http://trac.webkit.org/changeset/222705>
Comment 3 WebKit Commit Bot 2017-10-02 05:17:29 PDT
All reviewed patches have been landed.  Closing bug.