Bug 177569

Summary: Sync SYSTEM_MALLOC implementation of Gigacage
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: bmallocAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cmarcelo, commit-queue, dbates, fpizlo, ggaren, mark.lam, msaboff, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Don Olmstead
Reported 2017-09-27 14:45:05 PDT
The interface of Gigacage was changed in https://bugs.webkit.org/show_bug.cgi?id=174972 but the SYSTEM_MALLOC implementation in WTF was not updated.
Attachments
Patch (1.82 KB, patch)
2017-09-27 14:47 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (1.65 KB, patch)
2017-09-27 18:41 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-09-27 14:47:08 PDT
Created attachment 322018 [details] Patch Putting up for review to make sure this is the correct fix
Don Olmstead
Comment 2 2017-09-27 14:49:45 PDT
This should fix the WinCairo build which is x64 https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/6661/steps/compile-webkit/logs/stdio
Don Olmstead
Comment 3 2017-09-27 18:41:21 PDT
Created attachment 322052 [details] Patch Rebasing after https://bugs.webkit.org/show_bug.cgi?id=177565
Radar WebKit Bug Importer
Comment 4 2017-09-28 07:58:07 PDT
<rdar://problem/34713975>
Mark Lam
Comment 5 2017-09-28 10:02:17 PDT
Comment on attachment 322052 [details] Patch r=me if this has been tested to work. Is it tested?
Don Olmstead
Comment 6 2017-09-28 10:10:07 PDT
Comment on attachment 322052 [details] Patch It was building and running locally for me.
WebKit Commit Bot
Comment 7 2017-09-28 10:37:37 PDT
Comment on attachment 322052 [details] Patch Clearing flags on attachment: 322052 Committed r222615: <http://trac.webkit.org/changeset/222615>
WebKit Commit Bot
Comment 8 2017-09-28 10:37:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.