Bug 177393

Summary: REGRESSION(r221632): Re-enable configuration.HTTPCookieStorage on session without credentials
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit2Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, hello, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=177394
https://bugs.webkit.org/show_bug.cgi?id=176386
https://bugs.webkit.org/show_bug.cgi?id=177452
Bug Depends on:    
Bug Blocks: 177452    
Attachments:
Description Flags
Patch none

Description John Wilander 2017-09-22 15:34:14 PDT
The following setting on m_statelessSession (used to be m_sessionWithoutCredentialStorage) caused regressions on a number of sites:
configuration.HTTPCookieStorage = nil;
configuration.HTTPCookieAcceptPolicy = NSHTTPCookieAcceptPolicyNever;

We should re-enable the cookie jar until we've figured out the cause of the regression.
Comment 1 John Wilander 2017-09-22 15:36:03 PDT
Follow-up investigation to be handled in https://bugs.webkit.org/show_bug.cgi?id=177394.
Comment 2 Radar WebKit Bug Importer 2017-09-22 15:43:53 PDT
<rdar://problem/34604929>
Comment 3 John Wilander 2017-09-22 15:47:50 PDT
Created attachment 321597 [details]
Patch
Comment 4 Brent Fulgham 2017-09-22 16:09:01 PDT
Comment on attachment 321597 [details]
Patch

r=me
Comment 5 John Wilander 2017-09-22 16:09:50 PDT
Comment on attachment 321597 [details]
Patch

Thanks, Brent!
Comment 6 WebKit Commit Bot 2017-09-22 16:37:27 PDT
Comment on attachment 321597 [details]
Patch

Clearing flags on attachment: 321597

Committed r222414: <http://trac.webkit.org/changeset/222414>
Comment 7 WebKit Commit Bot 2017-09-22 16:37:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 John Wilander 2017-10-04 09:41:44 PDT
*** Bug 177809 has been marked as a duplicate of this bug. ***