Bug 177287

Summary: Web Inspector: Remove support for CSS Regions
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, buildbot, commit-queue, hyatt, inspector-bugzilla-changes, joepeck, keith_miller, koivisto, mark.lam, mattbaker, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=177249
Bug Depends on:    
Bug Blocks: 174978    
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2017-09-20 18:56:31 PDT 
Remove support for CSS Regions.

Part of the overall:
<https://webkit.org/b/174978> Remove support for CSS regions

CSS Domain:

    "id": "Region",
    "id": "NamedFlow",
    "name": "getNamedFlowCollection",
    "namedFlowCreated",
    "namedFlowRemoved",
    "regionOversetChanged",
    "registeredNamedFlowContentElement",
    "unregisteredNamedFlowContentElement",

And related Frontend handling of Regions.

Note:
- We MUST leave in the observer points at the least.
- Maybe leave stuff in so older backends still have something to show? Probably not though.
Comment 1 Joseph Pecoraro 2017-09-21 11:49:25 PDT 
As others have pointed out, we should remove associated tests as well.
Comment 2 Joseph Pecoraro 2017-09-21 13:24:59 PDT 
Created attachment 321471 [details]
[PATCH] Proposed Fix
Comment 3 Build Bot 2017-09-21 13:27:58 PDT 
Attachment 321471 [details] did not pass style-queue:


ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/TestExpectations:1506:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1778:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1779:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1780:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac/TestExpectations:1781:  Path does not exist.  [test/expectations] [5]
Total errors found: 5 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Joseph Pecoraro 2017-09-21 13:31:47 PDT 
Created attachment 321472 [details]
[PATCH] Proposed Fix
Comment 5 Matt Baker 2017-09-21 14:09:47 PDT 
Comment on attachment 321472 [details]
[PATCH] Proposed Fix

r=me
Comment 6 WebKit Commit Bot 2017-09-21 15:32:53 PDT 
Comment on attachment 321472 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 321472

Committed r222356: <http://trac.webkit.org/changeset/222356>
Comment 7 WebKit Commit Bot 2017-09-21 15:32:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:19:19 PDT 
<rdar://problem/34693031>