Bug 177211

Summary:

Build libwebrtc unit tests executables

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

REOPENED

Severity:

Normal

CC:

achristensen, ap, buildbot, commit-queue, eric.carlson, ggaren, jlewis3, jonlee, keith_miller, ryanhaddad, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

177252, 177344, 177890

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none
Patch for landing	none
Patch	none
Patch	none
Patch	none
Patch for relanding	none

youenn fablet

Reported 2017-09-19 17:11:16 PDT

That is handy to build them when needed.

Attachments
Patch (6.60 MB, patch) 2017-09-19 18:48 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (6.60 MB, patch) 2017-09-19 21:17 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (6.59 MB, patch) 2017-09-20 10:33 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (6.60 MB, patch) 2017-09-20 11:05 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (822.09 KB, patch) 2017-09-21 10:33 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (823.10 KB, patch) 2017-09-21 12:15 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (816.46 KB, patch) 2017-09-21 13:02 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (816.48 KB, patch) 2017-09-21 14:15 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (819.01 KB, patch) 2017-09-22 16:54 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (1.02 MB, patch) 2017-09-24 10:25 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (1.05 MB, patch) 2017-09-24 21:03 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (1.05 MB, patch) 2017-09-24 21:29 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (1.06 MB, patch) 2017-09-25 09:56 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (1.22 MB, patch) 2017-09-25 10:58 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (710.82 KB, patch) 2017-09-25 17:14 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (710.67 KB, patch) 2017-09-26 16:14 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (710.19 KB, patch) 2017-09-26 16:17 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (701.65 KB, patch) 2017-09-28 13:53 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (708.86 KB, patch) 2017-10-02 10:36 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (704.22 KB, patch) 2017-10-02 14:25 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch for relanding (701.87 KB, patch) 2017-10-02 14:40 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (20) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2017-09-19 18:48:04 PDT

Created attachment 321276 [details] Patch

Alex Christensen

Comment 2 2017-09-19 18:50:40 PDT

We already have Source/ThirdParty/gtest. Could we just update that/move it instead?

youenn fablet

Comment 3 2017-09-19 18:51:20 PDT

This requires googletest to be upstreamed. I can try to trim up what to upstream. The current build approach is to build everything as a static library, which means that we compile everything twice. This may not be good for our bots, so the unittest new target would be optional by default and we need to find a way to activate it whenever useful. If we want to run these tests for every commit, we could add a new bot task that would run these tests and maybe compile them as part of a related task.

youenn fablet

Comment 4 2017-09-19 18:55:59 PDT

(In reply to Alex Christensen from comment #2) > We already have Source/ThirdParty/gtest. Could we just update that/move it > instead? I tried and it is currently failing. This gtest is including JSExportMacros.h from JSC so I guess that it is tailored for JSC/WebCore stuff. Reusing that test would then create an unnecessary libwebrtc dependency to JSC. Maybe we can remove the JSC/WebCore specific stuff from gtest?

youenn fablet

Comment 5 2017-09-19 21:17:21 PDT

Created attachment 321286 [details] Patch

Alex Christensen

Comment 6 2017-09-19 21:17:50 PDT

Hmmm. Could we upstream googletest in a separate patch if we need to upstream it?

youenn fablet

Comment 7 2017-09-19 21:25:07 PDT

(In reply to Alex Christensen from comment #6) > Hmmm. > Could we upstream googletest in a separate patch if we need to upstream it? Sure. One issue with the current patch is that it activates compiling libwebrtc twice. The final version should disable that. If we do so, it will be probably easy to break it and notice it late only. Or maybe there is an easy way to activate targets for some specific configurations?

youenn fablet

Comment 8 2017-09-20 10:33:33 PDT

Created attachment 321329 [details] Patch

youenn fablet

Comment 9 2017-09-20 11:05:59 PDT

Created attachment 321336 [details] Patch

youenn fablet

Comment 10 2017-09-21 10:33:38 PDT

Created attachment 321444 [details] Patch

Build Bot

Comment 11 2017-09-21 10:36:32 PDT

Attachment 321444 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 12 2017-09-21 12:15:21 PDT

Created attachment 321461 [details] Patch

Build Bot

Comment 13 2017-09-21 12:16:35 PDT

Attachment 321461 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 3 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 14 2017-09-21 13:02:32 PDT

Created attachment 321467 [details] Patch

Build Bot

Comment 15 2017-09-21 13:05:18 PDT

Attachment 321467 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 3 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 16 2017-09-21 14:15:09 PDT

Created attachment 321477 [details] Patch

Build Bot

Comment 17 2017-09-21 14:17:56 PDT

Attachment 321477 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 3 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 18 2017-09-22 16:54:30 PDT

Created attachment 321604 [details] Patch

Build Bot

Comment 19 2017-09-23 21:04:20 PDT

Attachment 321604 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 9 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 20 2017-09-24 10:25:20 PDT

Created attachment 321655 [details] Patch

Build Bot

Comment 21 2017-09-24 10:27:45 PDT

Attachment 321655 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 9 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 22 2017-09-24 21:03:01 PDT

Created attachment 321665 [details] Patch

Build Bot

Comment 23 2017-09-24 21:04:25 PDT

Attachment 321665 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 9 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 24 2017-09-24 21:29:25 PDT

Created attachment 321667 [details] Patch

Build Bot

Comment 25 2017-09-24 21:31:15 PDT

Attachment 321667 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 9 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 26 2017-09-25 09:56:07 PDT

Created attachment 321695 [details] Patch

Build Bot

Comment 27 2017-09-25 09:58:51 PDT

Attachment 321695 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 9 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 28 2017-09-25 10:58:34 PDT

Created attachment 321702 [details] Patch

youenn fablet

Comment 29 2017-09-25 10:59:52 PDT

libwebrtc.dylib size now gets bigger from 9MB up to 10MB with these changes as we no longer strip some code that is only used for testing. Some optimization might be doable there if really necessary.

Build Bot

Comment 30 2017-09-25 11:01:29 PDT

Attachment 321702 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 9 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 31 2017-09-25 17:14:09 PDT

Created attachment 321776 [details] Patch

Build Bot

Comment 32 2017-09-25 17:34:12 PDT

Attachment 321776 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 9 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 33 2017-09-26 16:03:09 PDT

Comment on attachment 321776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321776&action=review > Source/ThirdParty/libwebrtc/ChangeLog:15 > + The static libwebrtc library is then linked to each unit test executable. libwebrtctest

youenn fablet

Comment 34 2017-09-26 16:14:09 PDT

Created attachment 321884 [details] Patch for landing

youenn fablet

Comment 35 2017-09-26 16:17:33 PDT

Created attachment 321886 [details] Patch for landing

Build Bot

Comment 36 2017-09-26 16:19:00 PDT

Attachment 321886 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 9 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 37 2017-09-26 17:38:04 PDT

Comment on attachment 321886 [details] Patch for landing Clearing flags on attachment: 321886 Committed r222537: <http://trac.webkit.org/changeset/222537>

WebKit Commit Bot

Comment 38 2017-09-26 17:38:06 PDT

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 39 2017-09-27 09:10:31 PDT

Reverted r222537 for reason: This change broke internal builds. Committed r222555: <http://trac.webkit.org/changeset/222555>

youenn fablet

Comment 40 2017-09-28 13:53:37 PDT

Created attachment 322112 [details] Patch

Build Bot

Comment 41 2017-09-28 13:55:45 PDT

Attachment 322112 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 9 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

youenn fablet

Comment 42 2017-09-29 09:33:59 PDT

Retrying landing. Patch no longer include a target which had no file to compile.

WebKit Commit Bot

Comment 43 2017-09-29 10:05:42 PDT

Comment on attachment 322112 [details] Patch Clearing flags on attachment: 322112 Committed r222652: <http://trac.webkit.org/changeset/222652>

WebKit Commit Bot

Comment 44 2017-09-29 10:05:44 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 45 2017-09-29 10:07:42 PDT

<rdar://problem/34741355>

Matt Lewis

Comment 46 2017-09-29 15:25:21 PDT

Reverted r222652 for reason: This broke an internal build. Committed r222668: <http://trac.webkit.org/changeset/222668>

youenn fablet

Comment 47 2017-10-02 10:35:13 PDT

There is a missing symbol FunctionThatDoesNothingImpl for asan build which does not get exported and is needed. The simplest approach is to compile the file that contains the symbol in libwebrtc static library.

youenn fablet

Comment 48 2017-10-02 10:36:13 PDT

Created attachment 322388 [details] Patch

youenn fablet

Comment 49 2017-10-02 14:25:54 PDT

Created attachment 322436 [details] Patch

youenn fablet

Comment 50 2017-10-02 14:40:37 PDT

Created attachment 322443 [details] Patch for relanding

Build Bot

Comment 51 2017-10-02 14:43:43 PDT

Attachment 322443 [details] did not pass style-queue: ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gtest.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/test/gmock.h:17: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:16: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:28: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/webrtc/common_audio/resampler/include/push_resampler.h:45: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/ThirdParty/libwebrtc/Source/third_party/gflags/gen/posix/include/private/config.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] Total errors found: 9 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 52 2017-10-03 02:43:53 PDT

Comment on attachment 322443 [details] Patch for relanding Clearing flags on attachment: 322443 Committed r222775: <http://trac.webkit.org/changeset/222775>

WebKit Commit Bot

Comment 53 2017-10-03 02:43:56 PDT

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 54 2017-10-03 20:26:21 PDT

Can we avoid doing this? This adds 3-4 minutes to production build time, which is a huge huge number.

WebKit Commit Bot

Comment 55 2017-10-04 12:27:17 PDT

Re-opened since this is blocked by bug 177890

Note You need to log in before you can comment on or make changes to this bug.