Bug 177066

Summary: WSL needs to annotate vertex shaders and fragment shaders
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, keith_miller, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
Patch fpizlo: review+

Myles C. Maxfield
Reported 2017-09-17 20:05:55 PDT
WSL needs to annotate vertex shaders and fragment shaders
Attachments
Patch (8.34 KB, patch)
2017-09-17 20:07 PDT, Myles C. Maxfield 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2017-09-17 20:07:16 PDT
Created attachment 321069 [details] Patch
Filip Pizlo
Comment 2 2017-09-18 15:00:36 PDT
Comment on attachment 321069 [details] Patch ProtocolFuncDecl needs to know about shaderType as well
Filip Pizlo
Comment 3 2017-09-18 15:28:00 PDT
(In reply to Filip Pizlo from comment #2) > Comment on attachment 321069 [details] > Patch > > ProtocolFuncDecl needs to know about shaderType as well Never mind, I'm wrong.
Filip Pizlo
Comment 4 2017-09-18 15:28:08 PDT
Comment on attachment 321069 [details] Patch LGTM.
Myles C. Maxfield
Comment 5 2017-09-18 15:39:55 PDT
Committed r222185: <http://trac.webkit.org/changeset/222185>
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:29:36 PDT
<rdar://problem/34693375>
Myles C. Maxfield
Comment 7 2018-10-13 16:29:23 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/123
Note You need to log in before you can comment on or make changes to this bug.