Bug 177066 - WSL needs to annotate vertex shaders and fragment shaders
Summary: WSL needs to annotate vertex shaders and fragment shaders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency tree / graph
 
Reported: 2017-09-17 20:05 PDT by Myles C. Maxfield
Modified: 2018-10-13 16:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.34 KB, patch)
2017-09-17 20:07 PDT, Myles C. Maxfield 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-09-17 20:05:55 PDT 
WSL needs to annotate vertex shaders and fragment shaders
Comment 1 Myles C. Maxfield 2017-09-17 20:07:16 PDT 
Created attachment 321069 [details]
Patch
Comment 2 Filip Pizlo 2017-09-18 15:00:36 PDT 
Comment on attachment 321069 [details]
Patch

ProtocolFuncDecl needs to know about shaderType as well
Comment 3 Filip Pizlo 2017-09-18 15:28:00 PDT 
(In reply to Filip Pizlo from comment #2)
> Comment on attachment 321069 [details]
> Patch
> 
> ProtocolFuncDecl needs to know about shaderType as well

Never mind, I'm wrong.
Comment 4 Filip Pizlo 2017-09-18 15:28:08 PDT 
Comment on attachment 321069 [details]
Patch

LGTM.
Comment 5 Myles C. Maxfield 2017-09-18 15:39:55 PDT 
Committed r222185: <http://trac.webkit.org/changeset/222185>
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:29:36 PDT 
<rdar://problem/34693375>
Comment 7 Myles C. Maxfield 2018-10-13 16:29:23 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/123