Bug 176997

Summary: [GTK] Bump fontconfig version to 2.12.4
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro, pnormand
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=177228
Attachments:
Description Flags
Patch
none
Patch mcatanzaro: review+

Description Carlos Garcia Campos 2017-09-15 05:45:05 PDT 
It's the latest stable version and we can get rid of the patches we have.
Comment 1 Carlos Garcia Campos 2017-09-15 05:49:07 PDT 
Created attachment 320894 [details]
Patch

I've also removed the osx patch, because I'm not happy patching fontconfig (unless it's really needed). If it's still needed someone involved in macos should propose a new patch and explain what it does and why it's needed.
Comment 2 Carlos Garcia Campos 2017-09-15 05:50:25 PDT 
Created attachment 320895 [details]
Patch

Fix the version number in the ChangeLog, it's 2.12.4.
Comment 3 Michael Catanzaro 2017-09-15 06:57:24 PDT 
Comment on attachment 320895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320895&action=review

> Tools/ChangeLog:16
> +        * gtk/patches/fontconfig-fix-osx-cache.diff: Removed.

Philippe added this patch in bug #150799. I would either keep it, or ask him before removing it.
Comment 4 Carlos Garcia Campos 2017-09-15 08:26:51 PDT 
(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 320895 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320895&action=review
> 
> > Tools/ChangeLog:16
> > +        * gtk/patches/fontconfig-fix-osx-cache.diff: Removed.
> 
> Philippe added this patch in bug #150799. I would either keep it, or ask him
> before removing it.

It's not needed for tests, so it can be added in a follow up in any case. I think we should set a more restrictive policy to patch deps in jhbuild. But meanwhile, it's better to remove patches we don't need than keeping them, not the other way around.
Comment 5 Philippe Normand 2017-09-15 09:19:32 PDT 
Comment on attachment 320895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320895&action=review

>>> Tools/ChangeLog:16
>>> +        * gtk/patches/fontconfig-fix-osx-cache.diff: Removed.
>> 
>> Philippe added this patch in bug #150799. I would either keep it, or ask him before removing it.
> 
> It's not needed for tests, so it can be added in a follow up in any case. I think we should set a more restrictive policy to patch deps in jhbuild. But meanwhile, it's better to remove patches we don't need than keeping them, not the other way around.

I agree with Carlos. The most recent Fontconfig releases might even have fixed this bug anyway.
Comment 6 Carlos Garcia Campos 2017-09-16 02:27:33 PDT 
Committed r222128: <http://trac.webkit.org/changeset/222128>