Bug 176978

Summary: WSL should support switch
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebGPUAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: keith_miller, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
work in progress
none
maybe it might work
none
seems to work
none
the patch keith_miller: review+

Filip Pizlo
Reported 2017-09-14 21:32:47 PDT
...
Attachments
work in progress (10.12 KB, patch)
2017-09-19 09:37 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
maybe it might work (19.18 KB, patch)
2017-09-19 11:50 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
seems to work (22.89 KB, patch)
2017-09-20 18:55 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (66.16 KB, patch)
2017-09-20 21:46 PDT, Filip Pizlo 		keith_miller: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-09-19 09:37:11 PDT
Created attachment 321204 [details] work in progress
Filip Pizlo
Comment 2 2017-09-19 11:50:58 PDT
Created attachment 321226 [details] maybe it might work
Filip Pizlo
Comment 3 2017-09-20 18:55:32 PDT
Created attachment 321399 [details] seems to work I still need to write more tests, like tests for the interaction between enum and switch.
Filip Pizlo
Comment 4 2017-09-20 21:46:59 PDT
Created attachment 321409 [details] the patch
Keith Miller
Comment 5 2017-09-21 10:39:40 PDT
Comment on attachment 321409 [details] the patch r=me.
Filip Pizlo
Comment 6 2017-09-21 10:51:24 PDT
Landed in https://trac.webkit.org/changeset/222330/webkit
Radar WebKit Bug Importer
Comment 7 2017-09-27 12:27:42 PDT
<rdar://problem/34693320>
Myles C. Maxfield
Comment 8 2018-10-13 16:38:58 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/132
Note You need to log in before you can comment on or make changes to this bug.