Bug 176978 - WSL should support switch
Summary: WSL should support switch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency treegraph
 
Reported: 2017-09-14 21:32 PDT by Filip Pizlo
Modified: 2018-10-13 16:38 PDT (History)
2 users (show)

See Also:


Attachments
work in progress (10.12 KB, patch)
2017-09-19 09:37 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
maybe it might work (19.18 KB, patch)
2017-09-19 11:50 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
seems to work (22.89 KB, patch)
2017-09-20 18:55 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (66.16 KB, patch)
2017-09-20 21:46 PDT, Filip Pizlo
keith_miller: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-09-14 21:32:47 PDT
...
Comment 1 Filip Pizlo 2017-09-19 09:37:11 PDT
Created attachment 321204 [details]
work in progress
Comment 2 Filip Pizlo 2017-09-19 11:50:58 PDT
Created attachment 321226 [details]
maybe it might work
Comment 3 Filip Pizlo 2017-09-20 18:55:32 PDT
Created attachment 321399 [details]
seems to work

I still need to write more tests, like tests for the interaction between enum and switch.
Comment 4 Filip Pizlo 2017-09-20 21:46:59 PDT
Created attachment 321409 [details]
the patch
Comment 5 Keith Miller 2017-09-21 10:39:40 PDT
Comment on attachment 321409 [details]
the patch

r=me.
Comment 6 Filip Pizlo 2017-09-21 10:51:24 PDT
Landed in https://trac.webkit.org/changeset/222330/webkit
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:27:42 PDT
<rdar://problem/34693320>
Comment 8 Myles C. Maxfield 2018-10-13 16:38:58 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/132