Summary: | Dragging & dropping a file creates an attachment element even when it's disabled | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, cdumez, commit-queue, darin, enrica, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=209210 | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 170449 | ||||||||||||
Attachments: |
|
Description
Ryosuke Niwa
2017-09-12 00:28:00 PDT
Created attachment 320527 [details]
Patch
Created attachment 320529 [details]
Fixed tests
Comment on attachment 320529 [details] Fixed tests Attachment 320529 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4522204 New failing tests: fast/attachment/attachment-select-on-click.html accessibility/ios-simulator/attributed-string-for-range.html Created attachment 320533 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Comment on attachment 320529 [details] Fixed tests View in context: https://bugs.webkit.org/attachment.cgi?id=320529&action=review Woo! Thank you for fixing this :) It has haunted the back of my mind for years. > Source/WebCore/ChangeLog:12 > + To fix the bug that HTMLAttachElement is always exposed on the global object even when it's disabled HTMLAttachmentElement. Created attachment 320566 [details]
Patch for landing
Comment on attachment 320566 [details]
Patch for landing
Wait for EWS.
Comment on attachment 320566 [details] Patch for landing Clearing flags on attachment: 320566 Committed r221944: <http://trac.webkit.org/changeset/221944> All reviewed patches have been landed. Closing bug. |