Bug 176677

Summary: WSL Substitution should probably wrap type variables of substituted types rather than just wrapping the whole type
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebGPUAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
the patch
none
the patch mmaxfield: review+

Filip Pizlo
Reported 2017-09-10 15:35:25 PDT
...
Attachments
the patch (20.28 KB, patch)
2017-09-11 11:46 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (22.04 KB, patch)
2017-09-11 12:19 PDT, Filip Pizlo 		mmaxfield: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-09-10 15:39:06 PDT
I think that Substitution should do something akin to CheckWrapped, but instead of throwing errors, it should just wrap the bad thing.
Filip Pizlo
Comment 2 2017-09-11 11:44:05 PDT
*** Bug 176678 has been marked as a duplicate of this bug. ***
Filip Pizlo
Comment 3 2017-09-11 11:46:10 PDT
Created attachment 320449 [details] the patch
Filip Pizlo
Comment 4 2017-09-11 12:19:07 PDT
Created attachment 320454 [details] the patch
Filip Pizlo
Comment 5 2017-09-11 14:20:23 PDT
Comment on attachment 320454 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=320454&action=review > Tools/WebGPUShadingLanguageRI/AutoWrapper.js:45 > + return TypeRef.wrap(node); This should be VariableRef.wrap
Myles C. Maxfield
Comment 6 2017-09-11 15:41:13 PDT
Comment on attachment 320454 [details] the patch Looks good.
Filip Pizlo
Comment 7 2017-09-11 16:00:18 PDT
Landed in https://trac.webkit.org/changeset/221888/webkit
Radar WebKit Bug Importer
Comment 8 2017-09-27 13:01:34 PDT
<rdar://problem/34694498>
Myles C. Maxfield
Comment 9 2018-10-13 16:50:42 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/143
Note You need to log in before you can comment on or make changes to this bug.