Bug 176463

Summary: Move test expectations from 'mac-highsierra' to 'mac' directory
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Ryan Haddad <ryanhaddad>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, jlewis3, lforschler, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 176699    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing ryanhaddad: commit-queue-

Ryan Haddad
Reported 2017-09-06 09:23:00 PDT
Move test expectations from 'mac-highsierra' to 'mac' directory
Attachments
Patch (14.69 MB, patch)
2017-09-06 14:54 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch (16.12 MB, patch)
2017-09-07 10:04 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch (14.70 MB, patch)
2017-09-14 15:35 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch (14.72 MB, patch)
2017-09-14 17:00 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.72 MB, patch)
2017-09-15 09:28 PDT, Ryan Haddad 		ryanhaddad: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2017-09-06 14:54:24 PDT
Created attachment 320063 [details] Patch Patch for EWS
Build Bot
Comment 2 2017-09-06 15:05:59 PDT
Attachment 320063 [details] did not pass style-queue: ERROR: LayoutTests/ChangeLog:9: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 237 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryan Haddad
Comment 3 2017-09-07 10:04:57 PDT
Created attachment 320123 [details] Patch
Build Bot
Comment 4 2017-09-07 10:20:10 PDT
Attachment 320123 [details] did not pass style-queue: ERROR: LayoutTests/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 303 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryan Haddad
Comment 5 2017-09-14 15:35:41 PDT
Created attachment 320834 [details] Patch
Build Bot
Comment 6 2017-09-14 15:49:06 PDT
Attachment 320834 [details] did not pass style-queue: ERROR: LayoutTests/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 239 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryan Haddad
Comment 7 2017-09-14 17:00:17 PDT
Created attachment 320846 [details] Patch
Build Bot
Comment 8 2017-09-14 17:11:55 PDT
Attachment 320846 [details] did not pass style-queue: ERROR: LayoutTests/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 248 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryan Haddad
Comment 9 2017-09-14 18:34:15 PDT
Finally all green :)
Ryan Haddad
Comment 10 2017-09-15 09:28:18 PDT
Created attachment 320910 [details] Patch for landing
Ryan Haddad
Comment 11 2017-09-15 14:21:06 PDT
Landed in <https://trac.webkit.org/changeset/222111>
Ryan Haddad
Comment 12 2017-09-15 16:46:44 PDT
Additional gardening for Sierra in <https://trac.webkit.org/r222117>
Radar WebKit Bug Importer
Comment 13 2017-09-27 13:08:34 PDT
<rdar://problem/34694687>
Note You need to log in before you can comment on or make changes to this bug.