Bug 176440

Summary:

WSL: Inliner doesn't allow double-negation

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

WebGPU

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, mmaxfield, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

176199

Attachments:

Description	Flags
the patch	mmaxfield: review+

Description Myles C. Maxfield 2017-09-05 22:23:08 PDT

doPrep() fails with "bool foo(bool x) { return !!x; }"

Comment 1 Filip Pizlo 2017-09-06 11:34:47 PDT

Created attachment 320043 [details]
the patch

Comment 2 Myles C. Maxfield 2017-09-06 11:53:06 PDT

Comment on attachment 320043 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320043&action=review

> Tools/WebGPUShadingLanguageRI/Parse.js:-649
> -            result.origin = operatorToken.origin;

Thanks

> Tools/WebGPUShadingLanguageRI/VisitingSet.js:36
> +            print("item: " + item + " (" + item.constructor.name + ")");

Print

Comment 3 Filip Pizlo 2017-09-06 13:04:17 PDT

Landed in https://trac.webkit.org/changeset/221692/webkit

Comment 4 Radar WebKit Bug Importer 2017-09-27 12:35:16 PDT

<rdar://problem/34693538>

Comment 5 Myles C. Maxfield 2018-10-13 16:58:06 PDT

Migrated to https://github.com/gpuweb/WHLSL/issues/150