Bug 176334

Summary: [WSL] Rationalize how protocol inheritance deals with type parameters
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebGPUAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: mark.lam, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
the patch
none
the patch mark.lam: review+

Filip Pizlo
Reported 2017-09-04 13:46:35 PDT
If a signature in a protocol has type parameters, then we should probably pass those type parameters as type arguments during inheritance resolution.
Attachments
the patch (7.60 KB, patch)
2017-09-07 10:26 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (7.87 KB, patch)
2017-09-07 10:34 PDT, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-09-07 10:26:41 PDT
Created attachment 320127 [details] the patch
Filip Pizlo
Comment 2 2017-09-07 10:34:45 PDT
Created attachment 320130 [details] the patch
Mark Lam
Comment 3 2017-09-07 10:48:26 PDT
Comment on attachment 320130 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=320130&action=review r=me > Tools/WebGPUShadingLanguageRI/ProtocolDecl.js:93 > + let overload = this.program.resolveFuncOverload(signature.name, signature.typeParameters, signature.parameterTypes); Not really due to this patch but "typeParameters" and "parameterTypes" sound too similar. Can there be better names for these?
Filip Pizlo
Comment 4 2017-09-07 10:52:58 PDT
(In reply to Mark Lam from comment #3) > Comment on attachment 320130 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=320130&action=review > > r=me > > > Tools/WebGPUShadingLanguageRI/ProtocolDecl.js:93 > > + let overload = this.program.resolveFuncOverload(signature.name, signature.typeParameters, signature.parameterTypes); > > Not really due to this patch but "typeParameters" and "parameterTypes" sound > too similar. Can there be better names for these? They are indeed confusing. But, they are terms of art.
Filip Pizlo
Comment 5 2017-09-07 10:54:15 PDT
Landed in https://trac.webkit.org/changeset/221740/webkit
Radar WebKit Bug Importer
Comment 6 2017-09-27 12:37:45 PDT
<rdar://problem/34693637>
Myles C. Maxfield
Comment 7 2018-10-13 17:00:12 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/152
Note You need to log in before you can comment on or make changes to this bug.