Summary: | [WSL] Rationalize how protocol inheritance deals with type parameters | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | WebGPU | Assignee: | Filip Pizlo <fpizlo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mark.lam, mmaxfield, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 176199 | ||||||||
Attachments: |
|
Description
Filip Pizlo
2017-09-04 13:46:35 PDT
Created attachment 320127 [details]
the patch
Created attachment 320130 [details]
the patch
Comment on attachment 320130 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=320130&action=review r=me > Tools/WebGPUShadingLanguageRI/ProtocolDecl.js:93 > + let overload = this.program.resolveFuncOverload(signature.name, signature.typeParameters, signature.parameterTypes); Not really due to this patch but "typeParameters" and "parameterTypes" sound too similar. Can there be better names for these? (In reply to Mark Lam from comment #3) > Comment on attachment 320130 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=320130&action=review > > r=me > > > Tools/WebGPUShadingLanguageRI/ProtocolDecl.js:93 > > + let overload = this.program.resolveFuncOverload(signature.name, signature.typeParameters, signature.parameterTypes); > > Not really due to this patch but "typeParameters" and "parameterTypes" sound > too similar. Can there be better names for these? They are indeed confusing. But, they are terms of art. Migrated to https://github.com/gpuweb/WHLSL/issues/152 |