Bug 176197

Summary: WSL should support makeptr (\)
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebGPUAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: mmaxfield, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
the patch saam: review+

Filip Pizlo
Reported 2017-08-31 17:03:20 PDT
Patch forthcoming.
Attachments
the patch (22.06 KB, patch)
2017-08-31 17:05 PDT, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-08-31 17:05:42 PDT
Created attachment 319543 [details] the patch
Saam Barati
Comment 2 2017-08-31 17:07:43 PDT
Comment on attachment 319543 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=319543&action=review > Tools/WebGPUShadingLanguageRI/Evaluator.js:132 > + throw new Error("Cannot get type or argument; i = " + i + ", argument = " + argument + ", type = " + type + "; in " + node); if you use a template literal here I'd think it'd be easier to read.
Filip Pizlo
Comment 3 2017-08-31 17:09:58 PDT
Landed in https://trac.webkit.org/changeset/221460/webkit
Radar WebKit Bug Importer
Comment 4 2017-09-27 12:47:41 PDT
<rdar://problem/34694027>
Myles C. Maxfield
Comment 5 2018-10-13 19:59:49 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/203
Note You need to log in before you can comment on or make changes to this bug.