Bug 176177

Summary: WSL parser should pass the token as the origin to the AST
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebGPUAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: keith_miller, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
the patch
none
the patch keith_miller: review+

Description Filip Pizlo 2017-08-31 12:42:41 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2017-08-31 12:44:57 PDT 
Created attachment 319503 [details]
the patch
Comment 2 Filip Pizlo 2017-08-31 12:46:26 PDT 
Created attachment 319504 [details]
the patch
Comment 3 Keith Miller 2017-08-31 12:48:45 PDT 
Comment on attachment 319504 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319504&action=review

r=me with nit.

> Tools/WebGPUShadingLanguageRI/Test.js:67
> +        () => prepare("<test>", 0, "int foo(int x) { return x + y; }"),

Nit: Seems like you might want to make a wrapper for prepare in this file. I expect you'll be calling it a lot...
Comment 4 Filip Pizlo 2017-08-31 12:52:19 PDT 
Landed in https://trac.webkit.org/changeset/221436/webkit
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:59:01 PDT 
<rdar://problem/34694419>
Comment 6 Myles C. Maxfield 2018-10-13 20:06:08 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/209