Bug 176171

Summary:

Make RenderStyle's non-inherited flags more human friendly

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

CSS

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, koivisto, rniwa, ryanhaddad, webkit-bug-importer, yoshiaki.jitsukawa

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

176210

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews114 for mac-elcapitan	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none
Patch	none
Another patch to fix the wincairo build	none

Daniel Bates

Reported 2017-08-31 10:34:06 PDT

Revert the change made in bug #130939 to make RenderStyle's non-inherited flags more JSC friendly as we never followed through to have the CSS JIT update RenderStyle directly.

Attachments
Patch (48.56 KB, patch) 2017-08-31 10:42 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (547.61 KB, application/zip) 2017-08-31 11:20 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (566.54 KB, application/zip) 2017-08-31 11:23 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-elcapitan (266.06 KB, application/zip) 2017-08-31 11:40 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (322.91 KB, application/zip) 2017-08-31 11:59 PDT, Build Bot	no flags	Details
Patch (53.70 KB, patch) 2017-08-31 15:25 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (53.83 KB, patch) 2017-08-31 15:27 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Another patch to fix the wincairo build (1.85 KB, patch) 2017-08-31 21:07 PDT, Yoshiaki Jitsukawa	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2017-08-31 10:42:09 PDT

Created attachment 319478 [details] Patch

Build Bot

Comment 2 2017-08-31 11:20:02 PDT Comment hidden (obsolete)

Comment on attachment 319478 [details] Patch Attachment 319478 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4417570 Number of test failures exceeded the failure limit.

Build Bot

Comment 3 2017-08-31 11:20:04 PDT Comment hidden (obsolete)

Created attachment 319484 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-08-31 11:23:41 PDT Comment hidden (obsolete)

Comment on attachment 319478 [details] Patch Attachment 319478 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4417579 Number of test failures exceeded the failure limit.

Build Bot

Comment 5 2017-08-31 11:23:42 PDT Comment hidden (obsolete)

Created attachment 319485 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-08-31 11:40:18 PDT Comment hidden (obsolete)

Comment on attachment 319478 [details] Patch Attachment 319478 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4417653 Number of test failures exceeded the failure limit.

Build Bot

Comment 7 2017-08-31 11:40:20 PDT Comment hidden (obsolete)

Created attachment 319488 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-08-31 11:59:21 PDT Comment hidden (obsolete)

Comment on attachment 319478 [details] Patch Attachment 319478 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4417718 Number of test failures exceeded the failure limit.

Build Bot

Comment 9 2017-08-31 11:59:22 PDT Comment hidden (obsolete)

Created attachment 319493 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Daniel Bates

Comment 10 2017-08-31 15:25:54 PDT

Created attachment 319529 [details] Patch

Daniel Bates

Comment 11 2017-08-31 15:27:30 PDT

Created attachment 319530 [details] Patch

Daniel Bates

Comment 12 2017-08-31 16:55:16 PDT

Comment on attachment 319530 [details] Patch Clearing flags on attachment: 319530 Committed r221459: <http://trac.webkit.org/changeset/221459>

Daniel Bates

Comment 13 2017-08-31 16:55:18 PDT

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 14 2017-08-31 18:13:07 PDT

This change broke the Windows build: C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\rendering\style\RenderStyle.h(1778): error C2666: 'WebCore::operator -': 7 overloads have similar conversions https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/4064

Daniel Bates

Comment 15 2017-08-31 19:02:29 PDT

(In reply to Ryan Haddad from comment #14) > This change broke the Windows build: > > C:\cygwin\home\buildbot\slave\win- > release\build\Source\WebCore\rendering\style\RenderStyle.h(1778): error > C2666: 'WebCore::operator -': 7 overloads have similar conversions > > https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/ > 4064 Committed attempt to fix the build in <http://trac.webkit.org/changeset/221467>.

Daniel Bates

Comment 16 2017-08-31 20:06:27 PDT

Committed another attempt to fix the Windows build <https://trac.webkit.org/changeset/221469>.

Yoshiaki Jitsukawa

Comment 17 2017-08-31 21:07:29 PDT

Created attachment 319571 [details] Another patch to fix the wincairo build

Radar WebKit Bug Importer

Comment 18 2017-09-27 12:43:27 PDT

<rdar://problem/34693833>

Note You need to log in before you can comment on or make changes to this bug.