Summary: | Speedometer 2.0: Add dummy node to notify app is ready for Backbone suite | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shiyu Zhang <shiyu.zhang> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | buildbot, cdumez, commit-queue, lforschler, rniwa, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | PC | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=176017 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 172339 | ||||||||
Attachments: |
|
Description
Shiyu Zhang
2017-08-30 20:16:58 PDT
Created attachment 319437 [details]
Patch
Comment on attachment 319437 [details]
Patch
A patch to fix this bug, PTAL.
Comment on attachment 319437 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319437&action=review > PerformanceTests/Speedometer/resources/tests.js:233 > + var newTodo = contentDocument.getElementsByClassName('new-todo'); > + newTodo[0].focus(); > + return newTodo[0]; I think it's cleaner to use querySelector here. Comment on attachment 319437 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319437&action=review >> PerformanceTests/Speedometer/resources/tests.js:233 >> + return newTodo[0]; > > I think it's cleaner to use querySelector here. Can we also replace checkboxes.length and deleteButtons.length by numberOfItemsToAdd below so that we'd see a console error should this bug come back? Created attachment 319831 [details]
Patch
Comment on attachment 319831 [details]
Patch
Thanks for your advice! A new patch following your suggestion is here.
Comment on attachment 319831 [details] Patch Clearing flags on attachment: 319831 Committed r221611: <http://trac.webkit.org/changeset/221611> All reviewed patches have been landed. Closing bug. |