Bug 175924

Summary:

Add support for RegExp "dotAll" flag

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, keith_miller, mark.lam, mathias, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Michael Saboff 2017-08-23 20:57:25 PDT

This is to add support for the ECMAScript proposed Regular Expression s (dotAll) flag.  See https://github.com/tc39/proposal-regexp-dotall-flag for details.

Comment 1 Michael Saboff 2017-08-23 20:57:53 PDT

<rdar://problem/33324894>

Comment 2 Michael Saboff 2017-08-24 13:05:42 PDT

Created attachment 319014 [details]
Patch

Comment 3 Keith Miller 2017-08-24 13:27:31 PDT

Comment on attachment 319014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319014&action=review

r=me.

> Source/JavaScriptCore/bytecode/BytecodeDumper.cpp:-263
> -    if (regExp->sticky())

Why'd you move sticky out of curiosity?

Comment 4 Michael Saboff 2017-08-24 13:34:13 PDT

(In reply to Keith Miller from comment #3)
> Comment on attachment 319014 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319014&action=review
> 
> r=me.
> 
> > Source/JavaScriptCore/bytecode/BytecodeDumper.cpp:-263
> > -    if (regExp->sticky())
> 
> Why'd you move sticky out of curiosity?

To alphabetize the option letters since the function is creating of those letters.

Comment 5 WebKit Commit Bot 2017-08-24 14:14:47 PDT

Comment on attachment 319014 [details]
Patch

Clearing flags on attachment: 319014

Committed r221160: <http://trac.webkit.org/changeset/221160>

Comment 6 WebKit Commit Bot 2017-08-24 14:14:49 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Michael Saboff 2017-09-26 12:26:27 PDT

*** Bug 172634 has been marked as a duplicate of this bug. ***