Bug 175784

Summary: [css-pseudo-4] Implement ::spelling-error and ::grammar-error
Product: WebKit Reporter: Daniel Bates <dbates>
Component: CSSAssignee: Daniel Bates <dbates>
Status: ASSIGNED ---    
Severity: Normal CC: buildbot, emilio, ews-watchlist, koivisto, rniwa, sebastianzartner
Priority: P2 Keywords: WebExposed
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on: 178232, 191040, 141774, 177265, 177490, 177493, 177882, 180984    
Bug Blocks:    
Attachments:
Description Flags
Work-in-progress
buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-elcapitan-wk2
none
Archive of layout-test-results from ews101 for mac-elcapitan
none
Archive of layout-test-results from ews113 for mac-elcapitan
none
Archive of layout-test-results from ews123 for ios-simulator-wk2
none
Work-in-progress patch
none
Work-in-progress patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews200 for win-future
none
Work-in-progress patch
none
Simple test none

Description Daniel Bates 2017-08-21 14:27:37 PDT
Implement pseudo elements spelling-error and grammar-error from <https://drafts.csswg.org/css-pseudo-4/> to allow a person to stylize the appearance of spelling and grammar errors, respectively.
Comment 1 Daniel Bates 2017-08-21 14:29:51 PDT
Created attachment 318674 [details]
Work-in-progress
Comment 2 Build Bot 2017-08-21 15:55:01 PDT Comment hidden (obsolete)
Comment 3 Build Bot 2017-08-21 15:55:02 PDT Comment hidden (obsolete)
Comment 4 Build Bot 2017-08-21 15:57:37 PDT Comment hidden (obsolete)
Comment 5 Build Bot 2017-08-21 15:57:38 PDT Comment hidden (obsolete)
Comment 6 Build Bot 2017-08-21 16:01:03 PDT Comment hidden (obsolete)
Comment 7 Build Bot 2017-08-21 16:01:05 PDT Comment hidden (obsolete)
Comment 8 Build Bot 2017-08-21 16:21:43 PDT Comment hidden (obsolete)
Comment 9 Build Bot 2017-08-21 16:21:45 PDT Comment hidden (obsolete)
Comment 10 Daniel Bates 2017-09-05 09:40:12 PDT
Created attachment 319907 [details]
Work-in-progress patch

The painting approach in this patch is wrong. We need to account for spelling and grammar errors that can overlap. This is demonstrated by the failure of the included test LayoutTests/fast/css/spelling-and-grammar-errors-overlap.html.
Comment 11 Daniel Bates 2018-03-19 11:50:54 PDT
Created attachment 336064 [details]
Work-in-progress patch
Comment 12 EWS Watchlist 2018-03-19 11:52:47 PDT
Attachment 336064 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/InlineTextBox.cpp:575:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/rendering/InlineTextBox.cpp:665:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/rendering/InlineTextBox.cpp:667:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 3 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 EWS Watchlist 2018-04-02 14:27:22 PDT
Comment on attachment 336064 [details]
Work-in-progress patch

Attachment 336064 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7182260

New failing tests:
fast/selectors/text-field-selection-stroke-color.html
fast/css/spelling-and-grammar-error-pseudo-elements-appearance.html
http/wpt/css/css-pseudo-4/spelling-error-001.html
fast/css/grammar-error-pseudo-element.html
fast/css/spelling-and-grammar-error-pseudo-elements-vertical-appearance.html
fast/css/paint-non-misspelled-text-between-spelling-errors-when-text-wraps.html
imported/blink/svg/text/selection-partial-gradient.html
fast/css/spelling-and-grammar-error-pseudo-elements-cursor.html
fast/css/spelling-and-grammar-errors-overlap.html
Comment 14 EWS Watchlist 2018-04-02 14:27:35 PDT
Created attachment 337030 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 15 Daniel Bates 2018-08-10 14:31:54 PDT
Created attachment 346924 [details]
Work-in-progress patch

Rebased patch and wired it up so that we paint background and decorations for spelling errors and grammar errors. I need to fix up the style computation so that styles are collected with respect to intersecting pseudo elements.
Comment 16 Daniel Bates 2018-08-10 14:36:47 PDT
Created attachment 346925 [details]
Simple test