Bug 175549

Summary: Add some convenience utility accessor methods to MacroAssembler::CPUState.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 174645    
Attachments:
Description Flags
proposed patch. saam: review+

Mark Lam
Reported 2017-08-14 15:17:51 PDT
Patch coming.
Attachments
proposed patch. (4.57 KB, patch)
2017-08-14 15:35 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-08-14 15:18:27 PDT
<rdar://problem/33884868>
Mark Lam
Comment 2 2017-08-14 15:35:56 PDT
Created attachment 318075 [details] proposed patch.
Saam Barati
Comment 3 2017-08-14 15:39:48 PDT
Comment on attachment 318075 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=318075&action=review > Source/JavaScriptCore/assembler/MacroAssembler.h:1869 > + template<typename T, typename std::enable_if<std::is_pointer<T>::value>::type* = nullptr> I don't think you need the = nullptr and the * type.
Mark Lam
Comment 4 2017-08-14 15:51:54 PDT
Thanks for the review. (In reply to Saam Barati from comment #3) > Comment on attachment 318075 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318075&action=review > > > Source/JavaScriptCore/assembler/MacroAssembler.h:1869 > > + template<typename T, typename std::enable_if<std::is_pointer<T>::value>::type* = nullptr> > > I don't think you need the = nullptr and the * type. Without the "* = nullptr", Clang complains: candidate template ignored: couldn't infer template argument ''. I'll land it as is.
Mark Lam
Comment 5 2017-08-14 15:56:01 PDT
Landed in r220720: <http://trac.webkit.org/r220720>.
Note You need to log in before you can comment on or make changes to this bug.