| Summary: | Add some convenience utility accessor methods to MacroAssembler::CPUState. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 174645 | ||||||
| Attachments: |
|
||||||
|
Description
Mark Lam
2017-08-14 15:17:51 PDT
Created attachment 318075 [details]
proposed patch.
Comment on attachment 318075 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=318075&action=review > Source/JavaScriptCore/assembler/MacroAssembler.h:1869 > + template<typename T, typename std::enable_if<std::is_pointer<T>::value>::type* = nullptr> I don't think you need the = nullptr and the * type. Thanks for the review. (In reply to Saam Barati from comment #3) > Comment on attachment 318075 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318075&action=review > > > Source/JavaScriptCore/assembler/MacroAssembler.h:1869 > > + template<typename T, typename std::enable_if<std::is_pointer<T>::value>::type* = nullptr> > > I don't think you need the = nullptr and the * type. Without the "* = nullptr", Clang complains: candidate template ignored: couldn't infer template argument ''. I'll land it as is. Landed in r220720: <http://trac.webkit.org/r220720>. |