Bug 175458

Summary:

Web Inspector: Styles: Update the filter icon to match Xcode

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, buildbot, commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

175450

Attachments:

Description	Flags
Patch	none
[Image] With patch applied	none
[Image] Xcode's icon offsets	none
Patch	none
[Image] With patch applied	none
Patch	none

Nikita Vasilyev

Reported 2017-08-10 16:28:15 PDT

Update the icon that is used: — At the bottom of the "Styles — Rules" panel. — Node panel, Event Listeners section.

Attachments
Patch (2.95 KB, patch) 2017-08-10 16:32 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
[Image] With patch applied (20.33 KB, image/png) 2017-08-10 16:44 PDT, Nikita Vasilyev	no flags	Details
[Image] Xcode's icon offsets (47.62 KB, image/png) 2017-08-10 17:28 PDT, Matt Baker	no flags	Details
Patch (13.06 KB, patch) 2017-08-11 13:08 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
[Image] With patch applied (6.63 KB, image/png) 2017-08-11 13:09 PDT, Nikita Vasilyev	no flags	Details
Patch (13.36 KB, patch) 2017-08-11 13:24 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-08-10 16:28:34 PDT

<rdar://problem/33838660>

Nikita Vasilyev

Comment 2 2017-08-10 16:32:32 PDT

Created attachment 317879 [details] Patch

Nikita Vasilyev

Comment 3 2017-08-10 16:44:23 PDT

Created attachment 317882 [details] [Image] With patch applied

Matt Baker

Comment 4 2017-08-10 17:28:08 PDT

Created attachment 317893 [details] [Image] Xcode's icon offsets We might as well match Xcode (assuming this is the system UI) exactly. I think our values are slightly off.

Matt Baker

Comment 5 2017-08-10 17:28:40 PDT

I'd also be in favor of changing the placeholder text to just "Filter", for all instances. I don't believe there is any ambiguity.

Nikita Vasilyev

Comment 6 2017-08-11 13:08:21 PDT

Created attachment 317953 [details] Patch

Nikita Vasilyev

Comment 7 2017-08-11 13:09:21 PDT

Created attachment 317954 [details] [Image] With patch applied Now it matches Xcode's spacing exactly.

Nikita Vasilyev

Comment 8 2017-08-11 13:24:36 PDT

Created attachment 317956 [details] Patch