Bug 175458

Summary: Web Inspector: Styles: Update the filter icon to match Xcode
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, buildbot, commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 175450    
Attachments:
Description Flags
Patch
none
[Image] With patch applied
none
[Image] Xcode's icon offsets
none
Patch
none
[Image] With patch applied
none
Patch none

Description Nikita Vasilyev 2017-08-10 16:28:15 PDT
Update the icon that is used:
— At the bottom of the "Styles — Rules" panel.
— Node panel, Event Listeners section.
Comment 1 Radar WebKit Bug Importer 2017-08-10 16:28:34 PDT
<rdar://problem/33838660>
Comment 2 Nikita Vasilyev 2017-08-10 16:32:32 PDT
Created attachment 317879 [details]
Patch
Comment 3 Nikita Vasilyev 2017-08-10 16:44:23 PDT
Created attachment 317882 [details]
[Image] With patch applied
Comment 4 Matt Baker 2017-08-10 17:28:08 PDT
Created attachment 317893 [details]
[Image] Xcode's icon offsets

We might as well match Xcode (assuming this is the system UI) exactly. I think our values are slightly off.
Comment 5 Matt Baker 2017-08-10 17:28:40 PDT
I'd also be in favor of changing the placeholder text to just "Filter", for all instances. I don't believe there is any ambiguity.
Comment 6 Nikita Vasilyev 2017-08-11 13:08:21 PDT
Created attachment 317953 [details]
Patch
Comment 7 Nikita Vasilyev 2017-08-11 13:09:21 PDT
Created attachment 317954 [details]
[Image] With patch applied

Now it matches Xcode's spacing exactly.
Comment 8 Nikita Vasilyev 2017-08-11 13:24:36 PDT
Created attachment 317956 [details]
Patch
Comment 9 Matt Baker 2017-08-11 13:27:13 PDT
Comment on attachment 317956 [details]
Patch

r=me
Comment 10 WebKit Commit Bot 2017-08-11 14:09:01 PDT
Comment on attachment 317956 [details]
Patch

Clearing flags on attachment: 317956

Committed r220609: <http://trac.webkit.org/changeset/220609>
Comment 11 WebKit Commit Bot 2017-08-11 14:09:03 PDT
All reviewed patches have been landed.  Closing bug.