Summary: | Web Inspector: Styles: Update the filter icon to match Xcode | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | agomez, buildbot, commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 175450 | ||||||||||||||||
Attachments: |
|
Description
Nikita Vasilyev
2017-08-10 16:28:15 PDT
Created attachment 317879 [details]
Patch
Created attachment 317882 [details]
[Image] With patch applied
Created attachment 317893 [details]
[Image] Xcode's icon offsets
We might as well match Xcode (assuming this is the system UI) exactly. I think our values are slightly off.
I'd also be in favor of changing the placeholder text to just "Filter", for all instances. I don't believe there is any ambiguity. Created attachment 317953 [details]
Patch
Created attachment 317954 [details]
[Image] With patch applied
Now it matches Xcode's spacing exactly.
Created attachment 317956 [details]
Patch
Comment on attachment 317956 [details]
Patch
r=me
Comment on attachment 317956 [details] Patch Clearing flags on attachment: 317956 Committed r220609: <http://trac.webkit.org/changeset/220609> All reviewed patches have been landed. Closing bug. |