Bug 175430

Summary: Web Inspector: Remove text-shadow and gradient backgrounds
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, nvasilyev, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 175450    
Attachments:
Description Flags
Patch
none
[Image] Autocomplete popover - before/after
none
[Image] Timelines call frames popover - before/after
none
[Image] Sidebar "No Filter Results" - before/after
none
Patch
none
Patch none

Matt Baker
Reported 2017-08-10 09:50:43 PDT
Summary: Remove text-shadow and gradient backgrounds. Web Inspector should be using a flat style throughout the UI.
Attachments
Patch (13.25 KB, patch)
2017-08-10 14:20 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Image] Autocomplete popover - before/after (146.69 KB, image/png)
2017-08-10 14:27 PDT, Matt Baker 		no flags
Details
[Image] Timelines call frames popover - before/after (94.40 KB, image/png)
2017-08-10 14:30 PDT, Matt Baker 		no flags
Details
[Image] Sidebar "No Filter Results" - before/after (112.82 KB, image/png)
2017-08-10 14:32 PDT, Matt Baker 		no flags
Details
Patch (13.28 KB, patch)
2017-08-10 14:37 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch (13.27 KB, patch)
2017-08-11 18:06 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2017-08-10 14:20:31 PDT
Created attachment 317845 [details] Patch
Matt Baker
Comment 2 2017-08-10 14:27:11 PDT
Created attachment 317846 [details] [Image] Autocomplete popover - before/after
Matt Baker
Comment 3 2017-08-10 14:30:14 PDT
Created attachment 317849 [details] [Image] Timelines call frames popover - before/after
Matt Baker
Comment 4 2017-08-10 14:32:38 PDT
Created attachment 317850 [details] [Image] Sidebar "No Filter Results" - before/after
Matt Baker
Comment 5 2017-08-10 14:34:04 PDT
The selected item background in the call frames popover should be full bleed (go all the way to the edges of the popover, be clipped by rounded corners) but this will be done in a follow-up.
Matt Baker
Comment 6 2017-08-10 14:37:43 PDT
Created attachment 317851 [details] Patch
Nikita Vasilyev
Comment 7 2017-08-10 17:06:41 PDT
Comment on attachment 317851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317851&action=review Looks good! One comment: > Source/WebInspectorUI/UserInterface/Views/RecordingTraceDetailsSidebarPanel.css:47 > - font-size: 13px; > + font-size: var(--sidebar-panel-content-message-font-size); Did you change the font size from 13px... > Source/WebInspectorUI/UserInterface/Views/Variables.css:61 > + --sidebar-panel-content-message-font-size: 16px; to 16px?
Matt Baker
Comment 8 2017-08-10 17:26:49 PDT
I did. Our font was much smaller than the same UI in Xcode and Mail. 16px is still smaller, but matching the size exactly felt too big.
Nikita Vasilyev
Comment 9 2017-08-11 16:07:01 PDT
(In reply to Matt Baker from comment #8) > I did. Our font was much smaller than the same UI in Xcode and Mail. 16px is > still smaller, but matching the size exactly felt too big. Does it affect anything other than "No Filter Results" message? If not, "--sidebar-panel-content-message-font-size" is too generic for a variable name.
Matt Baker
Comment 10 2017-08-11 18:06:14 PDT
Created attachment 317981 [details] Patch
Nikita Vasilyev
Comment 11 2017-08-11 18:36:25 PDT
Looks good to me, but I'm not a reviewer.
Blaze Burg
Comment 12 2017-08-14 10:27:17 PDT
Comment on attachment 317981 [details] Patch r=me There are other similar things to clean up, such as the popover's outline / drop shadow.
WebKit Commit Bot
Comment 13 2017-08-14 10:57:03 PDT
Comment on attachment 317981 [details] Patch Clearing flags on attachment: 317981 Committed r220710: <http://trac.webkit.org/changeset/220710>
WebKit Commit Bot
Comment 14 2017-08-14 10:57:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 15 2017-08-14 10:58:20 PDT
<rdar://problem/33878673>
Note You need to log in before you can comment on or make changes to this bug.