| Summary: | Web Inspector: Remove text-shadow and gradient backgrounds | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Baker <mattbaker> | ||||||||||||||
| Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, inspector-bugzilla-changes, nvasilyev, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 175450 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Matt Baker
2017-08-10 09:50:43 PDT
Created attachment 317845 [details]
Patch
Created attachment 317846 [details]
[Image] Autocomplete popover - before/after
Created attachment 317849 [details]
[Image] Timelines call frames popover - before/after
Created attachment 317850 [details]
[Image] Sidebar "No Filter Results" - before/after
The selected item background in the call frames popover should be full bleed (go all the way to the edges of the popover, be clipped by rounded corners) but this will be done in a follow-up. Created attachment 317851 [details]
Patch
Comment on attachment 317851 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317851&action=review Looks good! One comment: > Source/WebInspectorUI/UserInterface/Views/RecordingTraceDetailsSidebarPanel.css:47 > - font-size: 13px; > + font-size: var(--sidebar-panel-content-message-font-size); Did you change the font size from 13px... > Source/WebInspectorUI/UserInterface/Views/Variables.css:61 > + --sidebar-panel-content-message-font-size: 16px; to 16px? I did. Our font was much smaller than the same UI in Xcode and Mail. 16px is still smaller, but matching the size exactly felt too big. (In reply to Matt Baker from comment #8) > I did. Our font was much smaller than the same UI in Xcode and Mail. 16px is > still smaller, but matching the size exactly felt too big. Does it affect anything other than "No Filter Results" message? If not, "--sidebar-panel-content-message-font-size" is too generic for a variable name. Created attachment 317981 [details]
Patch
Looks good to me, but I'm not a reviewer. Comment on attachment 317981 [details]
Patch
r=me
There are other similar things to clean up, such as the popover's outline / drop shadow.
Comment on attachment 317981 [details] Patch Clearing flags on attachment: 317981 Committed r220710: <http://trac.webkit.org/changeset/220710> All reviewed patches have been landed. Closing bug. |