Bug 175272

Summary: Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, n_wang, ryanhaddad, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=174849
Attachments:
Description Flags
patch
none
patch none

Matt Lewis
Reported 2017-08-07 11:14:01 PDT
The test accessibility/press-target-uses-text-descendant-node.html is flaky on macOS Debug according to the flakiness dashboard. The test looks to have been flaky on these platforms since addition in https://trac.webkit.org/changeset/219906/webkit https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r220333%20(2400)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/2400 diff: --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/accessibility/press-target-uses-text-descendant-node-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/accessibility/press-target-uses-text-descendant-node-actual.txt @@ -4,10 +4,10 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -Clicked on element: SPAN Now pressing on button +Clicked on element: SPAN Clicked on element: IMG PASS successfullyParsed is true
Attachments
patch (1.39 KB, patch)
2017-08-09 12:33 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (2.03 KB, patch)
2017-08-10 15:08 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-08-07 11:14:19 PDT
<rdar://problem/33756962>
Nan Wang
Comment 2 2017-08-07 11:16:08 PDT
Will look into this
Nan Wang
Comment 3 2017-08-09 12:33:19 PDT
Created attachment 317729 [details] patch
chris fleizach
Comment 4 2017-08-09 13:44:57 PDT
Comment on attachment 317729 [details] patch is there some way that's more deterministic? could we post an internal notification when the press happens and listen for that?
Nan Wang
Comment 5 2017-08-10 15:08:57 PDT
Created attachment 317859 [details] patch update
WebKit Commit Bot
Comment 6 2017-08-10 18:41:59 PDT
Comment on attachment 317859 [details] patch Clearing flags on attachment: 317859 Committed r220570: <http://trac.webkit.org/changeset/220570>
WebKit Commit Bot
Comment 7 2017-08-10 18:42:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.