Bug 175272

Summary: Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, n_wang, ryanhaddad, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=174849
Attachments:
Description Flags
patch
none
patch none

Description Matt Lewis 2017-08-07 11:14:01 PDT 
The test accessibility/press-target-uses-text-descendant-node.html is flaky on macOS Debug according to the flakiness dashboard.

The test looks to have been flaky on these platforms since addition in https://trac.webkit.org/changeset/219906/webkit

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r220333%20(2400)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20(Tests)/builds/2400


diff:
--- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/accessibility/press-target-uses-text-descendant-node-expected.txt
+++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/accessibility/press-target-uses-text-descendant-node-actual.txt
@@ -4,10 +4,10 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-Clicked on element: SPAN
 
 Now pressing on button
 
+Clicked on element: SPAN
 Clicked on element: IMG
 PASS successfullyParsed is true
Comment 1 Radar WebKit Bug Importer 2017-08-07 11:14:19 PDT 
<rdar://problem/33756962>
Comment 2 Nan Wang 2017-08-07 11:16:08 PDT 
Will look into this
Comment 3 Nan Wang 2017-08-09 12:33:19 PDT 
Created attachment 317729 [details]
patch
Comment 4 chris fleizach 2017-08-09 13:44:57 PDT 
Comment on attachment 317729 [details]
patch

is there some way that's more deterministic? could we post an internal notification when the press happens and listen for that?
Comment 5 Nan Wang 2017-08-10 15:08:57 PDT 
Created attachment 317859 [details]
patch

update
Comment 6 WebKit Commit Bot 2017-08-10 18:41:59 PDT 
Comment on attachment 317859 [details]
patch

Clearing flags on attachment: 317859

Committed r220570: <http://trac.webkit.org/changeset/220570>
Comment 7 WebKit Commit Bot 2017-08-10 18:42:01 PDT 
All reviewed patches have been landed.  Closing bug.