Bug 174880

Summary:

Part 2 of: Rename DatabaseProcess to StorageProcess

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit2

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, buildbot, commit-queue

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=174879
https://bugs.webkit.org/show_bug.cgi?id=175034

Bug Depends on:

174961

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Brady Eidson

Reported 2017-07-26 17:02:24 PDT

Part 2 of: Rename DatabaseProcess to StorageProcess Part 1 renamed all of the relevant files on disk and then made the minimal set of code changes to keep things building. This part will go through all of WebKit and rename all the other things that are now obsolete.

Attachments
Patch (65.40 KB, patch) 2017-07-27 16:52 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (66.18 KB, patch) 2017-07-27 17:11 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (66.18 KB, patch) 2017-07-27 17:16 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (75.26 KB, patch) 2017-07-27 19:17 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (75.34 KB, patch) 2017-08-01 09:40 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2017-07-26 17:02:52 PDT

Part 1 - https://bugs.webkit.org/show_bug.cgi?id=174879

Brady Eidson

Comment 2 2017-07-27 16:52:10 PDT

Created attachment 316581 [details] Patch

Build Bot

Comment 3 2017-07-27 16:53:23 PDT

Attachment 316581 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/NetworkProcess.cpp:306: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/NetworkProcess.h:118: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 4 2017-07-27 16:57:12 PDT

Comment on attachment 316581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316581&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:315 > -void NetworkProcess::didGrantSandboxExtensionsToDatabaseProcessForBlobs(uint64_t requestID) > +void NetworkProcess::didgrantSandboxExtensionsToStorageProcessForBlobs(uint64_t requestID) Lower-case g doesn't look right. > Source/WebKit/NetworkProcess/NetworkProcess.h:200 > - void didGrantSandboxExtensionsToDatabaseProcessForBlobs(uint64_t requestID); > + void didgrantSandboxExtensionsToStorageProcessForBlobs(uint64_t requestID); Ditto. > Source/WebKit/NetworkProcess/NetworkProcess.messages.in:83 > - DidGrantSandboxExtensionsToDatabaseProcessForBlobs(uint64_t requestID) > + DidgrantSandboxExtensionsToStorageProcessForBlobs(uint64_t requestID) Ditto.

Brady Eidson

Comment 5 2017-07-27 17:11:38 PDT

Created attachment 316582 [details] Patch

Build Bot

Comment 6 2017-07-27 17:14:43 PDT

Attachment 316582 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/NetworkProcess.cpp:306: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/NetworkProcess.h:118: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 7 2017-07-27 17:16:57 PDT

Created attachment 316584 [details] Patch

Build Bot

Comment 8 2017-07-27 17:19:53 PDT

Attachment 316584 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/NetworkProcess.cpp:306: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/NetworkProcess.h:118: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 9 2017-07-27 19:17:06 PDT

Created attachment 316600 [details] Patch

Build Bot

Comment 10 2017-07-27 19:19:48 PDT

Attachment 316600 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/NetworkProcess.cpp:306: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/NetworkProcess.h:118: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 52 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 11 2017-07-27 20:32:38 PDT

Comment on attachment 316600 [details] Patch Clearing flags on attachment: 316600 Committed r219990: <http://trac.webkit.org/changeset/219990>

WebKit Commit Bot

Comment 12 2017-07-27 20:32:39 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 13 2017-07-28 16:42:00 PDT

<rdar://problem/33601771>

WebKit Commit Bot

Comment 14 2017-07-28 17:49:48 PDT

Re-opened since this is blocked by bug 174961

Brady Eidson

Comment 15 2017-08-01 09:40:25 PDT

Created attachment 316863 [details] Patch

Build Bot

Comment 16 2017-08-01 09:43:58 PDT

Attachment 316863 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/NetworkProcess.cpp:306: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit/NetworkProcess/NetworkProcess.h:118: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 52 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 17 2017-08-01 11:18:07 PDT

Comment on attachment 316863 [details] Patch Clearing flags on attachment: 316863 Committed r220105: <http://trac.webkit.org/changeset/220105>

WebKit Commit Bot

Comment 18 2017-08-01 11:18:09 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.