Bug 174849

Summary: AX: should dispatch accessibilityPerformPressAction async on MacOS
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, buildbot, cfleizach, dmazzoni, jcraig, jdiggs, n_wang, rniwa, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=175272
Attachments:
Description Flags
patch
buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-elcapitan
none
patch cfleizach: review+

Description Nan Wang 2017-07-25 18:05:12 PDT
If by performing press action on an object causes an alert to appear, VO will hang, because accessibilityPerformPressAction never gets a chance to return

<rdar://problem/32933114>
Comment 1 Nan Wang 2017-07-25 18:11:14 PDT
Created attachment 316414 [details]
patch
Comment 2 Build Bot 2017-07-25 19:08:57 PDT
Comment on attachment 316414 [details]
patch

Attachment 316414 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4187686

New failing tests:
accessibility/mac/search-predicate.html
media/media-controls-accessibility.html
Comment 3 Build Bot 2017-07-25 19:08:58 PDT
Created attachment 316419 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Nan Wang 2017-07-25 19:12:54 PDT
Created attachment 316421 [details]
patch

Fixed the test failure
Comment 5 chris fleizach 2017-07-26 00:18:06 PDT
Comment on attachment 316421 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316421&action=review

> LayoutTests/accessibility/mac/search-predicate.html:283
>          startElement = accessibilityController.focusedElement.childAtIndex(0);

looks like this block should be indented now
Comment 6 Nan Wang 2017-07-26 00:37:56 PDT
(In reply to chris fleizach from comment #5)
> Comment on attachment 316421 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316421&action=review
> 
> > LayoutTests/accessibility/mac/search-predicate.html:283
> >          startElement = accessibilityController.focusedElement.childAtIndex(0);
> 
> looks like this block should be indented now

Okay.
Comment 7 Nan Wang 2017-07-26 00:39:03 PDT
Committed r219906: <http://trac.webkit.org/changeset/219906>